Redact Authorization extra headers from command errors#2188
Merged
Byron merged 1 commit intoJul 26, 2026
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses credential leakage in GitPython error/log output by extending command-line redaction to cover http.*.extraHeader Authorization headers (e.g. when passed via -c http.extraHeader=Authorization: …), aligning behavior with existing URL user/pass redaction and fixing #1626.
Changes:
- Extend
remove_password_if_present()to redact*.extraHeader=Authorization: ...values while preserving the config key and header name. - Add direct unit coverage for
remove_password_if_present()redaction of Authorization extra headers. - Add an end-to-end regression test ensuring
GitCommandErrormessages do not include Authorization tokens.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
git/util.py |
Adds redaction logic for *.extraHeader=Authorization: arguments in remove_password_if_present(). |
test/test_util.py |
Adds a focused unit test covering Authorization extra header redaction. |
test/test_git.py |
Adds a regression test asserting Authorization tokens are redacted from GitCommandError messages. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1626.
Validation
AI agent disclosure
This pull request was prepared and submitted by OpenAI Codex acting as an AI agent through the contributor account.