ci: fix npm provenance URL by cd-ing into package dir#104
Merged
Conversation
npm publish <path> constructs the provenance git-remote URL incorrectly when the path argument is a subdirectory, yielding ssh://git@github.com/packages/gnome-shell.git instead of the repo remote. cd + bare `npm publish` resolves git remote correctly from the working directory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npm publish packages/gnome-shell --provenanceconstructs the git-remote URL incorrectly when given a path argument: it producedssh://git@github.com/packages/gnome-shell.gitinstead of the actual repo remote.Fix:
cd packages/gnome-shell && npm publish— npm resolves the git remote from the working directory instead.