Fix SignalMethods.connect callback return type - #133
Merged
Conversation
SignalMethods.connect typed its callback return as `boolean | undefined`, which rejected the common case of a handler that returns nothing — a void-returning function is not assignable to `boolean | undefined`. Use `boolean | void` so handlers may return nothing or `true` to stop emission, matching imports.signals semantics (only `true` stops emission). Closes #116
This was referenced Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SignalMethods.connecttyped its callback return asboolean | undefined. That rejects the most common handler shape — one that returns nothing — because a void-returning function is not assignable toboolean | undefined:Switching to
boolean | voidaccepts both a void-returning handler and one that returnstrueto stop emission, which matches theimports.signalsruntime semantics (onlytruestops emission — see_signals.js).Fixed here for now; the file already carries a
TODOto upstreamSignalMethodsinto@girs/gjs, where the same type lives — that's a separate change in the types generator.Validated locally (
build:types,prettier:check,validate:types,validate:example) — all green.Closes #116