Add configurable trajectory persistence and decouple thermo logging in melt-quench pipeline#395
Conversation
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
|
Thanks for the PR! Happy to merge after the minor changes discussed |
|
Working on a more unified version to avoid seperate definitions of the _run_lammps_md. Expect a major update of this PR today, also taking into account new option in lammpsparser that makes sure the last frame is dumped. |
|
Hey @Atilaac and @ltalirz, I also updated the notebooks and copied the changed notebooks to docs/notebooks (@Atilaac: I guess this now also requires the builddocs label ? also any other?) Please have again a look at the changes. PS: I am out of office tomorrow. We can discuss today or next week. |
| trajectories. | ||
| 2. On persistence, ``result_data['melt_quench']['simulation_history']`` is | ||
| extracted into the dedicated ``Job.simulation_history`` column. | ||
| 3. Storage policy is controlled by ``persist_structures``: |
There was a problem hiding this comment.
Let's make this more explicit
persist_trajectory:
"all":"last_frame"
and be explicit that we just store positions and cells (note: the prepare_for_history function needs to be adapted to also drop forces/velocities in case all)
|
@Gitdowski You may also be able to close #340 once this is merged |
3e5bde2 to
cc847ce
Compare
- fix: storing only last frame for structure averaging - fix: add independent n_dump & n_print_thermo intervalls - fix: unify _run_lammps_md - fix: add option to allow saving all dumps / keeping only last dump - fix: move n_averaging_frames and NVT simulation to structure analysis - fix: typing issue - fix: avoid unit conversion warnings for lammps runs - fix: tests & rerun notebooks - fix: remove structure from deprecated data - fix: improve docstrings - chore: update pixi.lock (#396) & pixi.toml for lammpsparser 0.0.7 - perf: faster job:search - perf: automatic number of cores - perf: faster glasses:search exact matches - perf: index created_at for fast date-range job search (#398)
cc847ce to
386486c
Compare
This PR (and its major reviews) improves melt-quench persistence and observability. It also seperates the NVT simulation required for structure analysis averaging if
n_averaging_frames > 1into the structure_analysis workflow.n_averaging_framesplumbing so user-provided values are respected end-to-end.n_printinton_dumpandn_print_thermoto decouple thermo log verbosity from sparse dump cadence.final_structurebehavior unchanged for downstream analyses.trajectory_storing_modeindependently for for melt-quench and structure analysis workflow to control what part of the trajectory/dump data enters the database:all_frames_all_datakeeps all data as recordedall_frames_drop_velocities_and_forceskeeps all dumped frames but removes potentially data-heavyforcesandvelocitieslast_frame_all_datareduces dump-related data (key-names in parsed_output: natoms, cells, indices, forces, velocities, unwrapped_positions, positions) to only the last recorded framelast_frame_drop_velocities_and_forceslast_frameoption is selected, the simulation history will contain the last structure of every stage.dump_final_structureparameter_run_lammps_mdfunction to avoid requiring multiple definitions of it