feat(go): --enum-type-name-suffix to avoid same-package enum conflicts#3085
Closed
alpoi wants to merge 4 commits into
Closed
feat(go): --enum-type-name-suffix to avoid same-package enum conflicts#3085alpoi wants to merge 4 commits into
alpoi wants to merge 4 commits into
Conversation
No generated-output differences✅ This PR does not change generated outputs. |
No generated-output differences✅ This PR does not change generated outputs. |
Member
|
I have to first sort out this Scale CI issue, apologies. |
No generated-output differences✅ This PR does not change generated outputs. |
Generated-output differences1 files differ — 0 modified, 1 new, 0 deleted |
Member
|
#3086 was a better fix, but I wouldn't have found it without your work. Thank you so much! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a
--enum-type-name-suffixflag (defaults to false) that will generate Golang enums with their type appended to member names (e.g.Red Colour = "RED"->RedColour Colour = "RED"), resolving an issue with conflicting enums in the same package.Related Issue
#2624
Motivation and Context
See the issue above for motivation / context, previous behaviour, new behaviour, and test instructions.