Skip to content

feat(typescript-zod): preserve named object unions #3103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
louis-bompart wants to merge 1 commit into
base: agent/fix-issue-1646-2
Choose a base branch
from
+13 −1
Open

feat(typescript-zod): preserve named object unions #3103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/quicktype-core/src/language/TypeScriptZod/language.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,10 @@ export class TypeScriptZodTargetLanguage extends TargetLanguage<
return true;
}

public get supportsUnionsWithMultipleObjectTypes(): boolean {
return true;
}

protected makeRenderer<Lang extends LanguageName = "typescript-zod">(
renderContext: RenderContext,
untypedOptionValues: RendererOptions<Lang>,
Expand Down
10 changes: 9 additions & 1 deletion test/unit/named-class-union.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ function schemaWithReusedRef(): object {
}

async function generate(
lang: "python" | "typescript",
lang: "python" | "typescript" | "typescript-zod",
operation: "oneOf" | "anyOf" = "oneOf",
schema: object = schemaWithUnion(operation),
): Promise<string> {
Expand Down Expand Up @@ -114,6 +114,14 @@ describe("named class unions (issue #1646)", () => {
expect(output).toContain("baz: Optional[str] = None");
});

test("TypeScript Zod preserves the named alternatives", async () => {
const output = await generate("typescript-zod");

expect(output).toContain("export const FooSchema = z.object({");
expect(output).toContain("export const BarSchema = z.object({");
expect(output).toContain('"op": z.union([FooSchema, BarSchema])');
});

test("languages that do not opt in keep the existing behavior", async () => {
const output = await generate("typescript");

Expand Down