fix(csharp): count System.Text.Json string bounds in code points - #3450
Merged
Conversation
* fix(dart): count Unicode code points in string bounds * test(dart): reuse shared Unicode length fixture
* fix(zod): count Unicode code points for string length * test(zod): use shared Unicode length cases
* fix(effect): count Unicode code points for string length * test(effect): use shared Unicode length cases
* fix(javascript): count Unicode code points for string length * test(javascript): use shared Unicode length cases
Generated-output differences6 files differ — 5 modified, 1 new, 0 deleted |
Generated-output differences6 files differ — 5 modified, 1 new, 0 deleted |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
System.Text.Json string bounds counted UTF-16 units, rejecting valid supplementary characters and accepting strings that were too short. Count Unicode code points only where length checks are emitted, without adding imports or warning pragmas.
Uses the shared Unicode fixtures from #3449. Split from #3446 to keep each renderer fix within 15 production lines; this fix changes 9.
Validation: build and Biome; four schema fixtures (19 positive/negative samples); unchanged output for combinations1 and pokedex. Local fixture runs used .NET 10 with
DOTNET_ROLL_FORWARD=Majorfor the .NET 8 target.