-
Notifications
You must be signed in to change notification settings - Fork 9
refactor: ♻️ Update Google Sheets docs for date format. #442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Clarify that dates must be in DD/MM/YYYY format.
WalkthroughUpdated the "Link Google Sheets" flow action documentation: standardized example date format to DD/MM/YYYY, added a Note specifying Google Sheets must store dates in DD/MM/YYYY (with locale/custom-format guidance), and expanded calendar functions to include Changes
Sequence Diagram(s)(omitted — changes are documentation-only and do not modify control flow) Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
🚀 Deployed on https://deploy-preview-442--glific-docs.netlify.app |
| _As per above example, the sheet `Daily Activity` is used to read the content from, and the variable `@calendar.current_date` D/MM/YYYY being passed from Glific to the Google sheet is being used as the search key to identify the relevant row to send the content from_ | ||
| _As per above example, the sheet `Daily Activity` is used to read the content from, and the variable `@calendar.current_date` DD/MM/YYYY being passed from Glific to the Google sheet is being used as the search key to identify the relevant row to send the content from_ | ||
|
|
||
| **Note**: It is important to note that dates in the sheet should be in the format `DD/MM/YYYY`. Any other format will not work as expected. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The issue was even though we only send the date in DD/MM/YYYY from Glific, Google sheet might be considering it as MM/DD/YYYY. So we need to make sure either the Settings -> Locale is India or the date column should be in DD/MM/YYYY format, which can be done from Format -> Number -> Custom Date and Time for a column.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed d1eeb65
Add instructions for setting DD/MM/YYYY format via locale or custom formatting options in Google Sheets.
Clarify that dates must be in DD/MM/YYYY format.
Summary by CodeRabbit