Contact Profiles: Added option to deactivate profile #156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Walkthrough
A new "Deactivate Profile" option was introduced to the contact profile flow, affecting both the available profile actions and the UI rendering logic. The flow editor's configuration was updated to include the "profile" filter. The ContactProfileRouter now conditionally displays a message when deactivating a profile. The helper function was updated to find profile options dynamically from a consolidated object.
## Changes
| File(s) | Change Summary |
|--------------------------------------------------------------------------------------------|------------------------------------------------------------------------------------------------------------------|
| public/index.html | Added `'profile'` to the flow editor's `filters` array in the configuration object. |
| src/components/flow/routers/contactprofile/ContactProfileRouterForm.tsx | Added "Deactivate Profile" option to selectable profile actions; removed `profileOptionsWithName`; removed blank line in `renderEdit`. |
| src/components/flow/routers/contactprofile/ContactProfileRouter.tsx | Added a conditional branch to render a message when `profile_type` is "Deactivate Profile". |
| src/components/flow/routers/contactprofile/helpers.ts | Removed import of `profileOptionsWithName`; updated `nodeToState` to find profile option by name within `profileOptions`. |
| package.json | Updated version number from "1.26.3-26" to "1.26.3-27". |
## Sequence Diagram(s)
```mermaid
sequenceDiagram
participant User
participant ContactProfileRouterForm
participant ContactProfileRouter
User->>ContactProfileRouterForm: Selects a profile action (including "Deactivate Profile")
ContactProfileRouterForm->>ContactProfileRouter: Passes selected profile_type and value
alt profile_type == "Deactivate Profile"
ContactProfileRouter->>User: Displays "Deactivating profile: <value>"
else profile_type == "Switch Profile" or "Update Name"
ContactProfileRouter->>User: Displays corresponding UI
endPoem
|
mdshamoon
reviewed
May 23, 2025
src/components/flow/routers/contactprofile/ContactProfileRouterForm.tsx
Outdated
Show resolved
Hide resolved
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
src/components/flow/routers/contactprofile/ContactProfileRouterForm.tsx(1 hunks)src/components/flow/routers/contactprofile/helpers.ts(2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- src/components/flow/routers/contactprofile/ContactProfileRouterForm.tsx
🧰 Additional context used
🧬 Code Graph Analysis (1)
src/components/flow/routers/contactprofile/helpers.ts (1)
src/components/flow/routers/contactprofile/ContactProfileRouterForm.tsx (1)
profileOptions(23-27)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Analyze (javascript-typescript)
- GitHub Check: Tests (12.x)
- GitHub Check: Coverage
🔇 Additional comments (2)
src/components/flow/routers/contactprofile/helpers.ts (2)
9-9: Good refactoring to consolidate profile options.The removal of
profileOptionsWithNameimport aligns with the consolidation of profile options into a singleprofileOptionsobject, reducing code duplication.
28-28: Assignment depends on null-safe lookup above.This assignment is correct, but ensure the
optionvariable is never undefined to prevent downstream issues in UI components that expect a valid option object.
mdshamoon
approved these changes
May 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
target issue is glific/glific-frontend#3311
Summary by CodeRabbit