chore: sunset automated Claude PR-review gate - #310
Conversation
All 4 known consumers have migrated to CodeRabbit, so the automated review gate that ran on every PR is no longer needed. Removes the pr-review/ composite action, the claude-pr-review.yml reusable workflow, its example caller, and the now-dead marker-emission-aggregate.yml (which only aggregated commit statuses posted by pr-review/action.yml). Fixes the entangled digest-pin rewrite tooling in runtime-build.yml/runtime-rollback.yml (5->4 workflows, 7->6 occurrences) and the test.yml marker-corpus job that would otherwise reference deleted files. Updates docs/comments accordingly. The separate interactive `@claude review` tag-comment path (claude-command-router -> claude-runtime-review overlay -> claude-tag-respond.yml) is untouched and remains fully functional. Closes #309 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 9 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe PR retires the Claude PR review action and workflow, removes related documentation and marker fixtures, updates digest promotion and rollback counts, adds router-case CI coverage, and refreshes remaining runtime and overlay comments. ChangesClaude PR review retirement
Possibly related issues
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Comment |
|
Claude finished @cbeaulieu-gt's task in 1m 50s —— View job Reviewing incremental changesTodo:
Files changed:
Review SummaryThis commit addresses the two CodeRabbit findings from the previous review. The changes are well-implemented and correctly fix the identified issues. ✅ Code Qualityoverlay-smoke.yml (.github/workflows/overlay-smoke.yml:45-64)
README.md (README.md:125,127)
consumer-onboarding.md (docs/consumer-onboarding.md:142-166)
✅ SecurityNo security concerns. The changes are documentation and workflow validation logic only. ✅ PerformanceThe ✅ Test CoverageThe conflict-detection logic (lines 56-61) is not covered by automated tests, but:
This is acceptable — the logic is defensive validation, not core business logic. ✅ Documentation
VerdictAPPROVE — All changes are correct, well-implemented fixes that directly address the CodeRabbit findings. No issues found. The conflict detection in |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 3e8edc61-b9ba-464c-936e-0050107a3553
📒 Files selected for processing (34)
.github/workflows/claude-pr-review.yml.github/workflows/marker-emission-aggregate.yml.github/workflows/overlay-smoke.yml.github/workflows/runtime-build.yml.github/workflows/runtime-rollback.yml.github/workflows/test.ymlCLAUDE.mdREADME.mddocs/consumer-onboarding.mdexamples/README.mdexamples/claude-pr-review.ymlpr-review/README.mdpr-review/action.ymlpr-review/lib/parse-marker.shpr-review/lib/severity-regex.shpr-review/tests/marker-cases/clean-review.expectedpr-review/tests/marker-cases/clean-review.mdpr-review/tests/marker-cases/marker-malformed.expectedpr-review/tests/marker-cases/marker-malformed.mdpr-review/tests/marker-cases/marker-missing.expectedpr-review/tests/marker-cases/marker-missing.mdpr-review/tests/marker-cases/mixed-severity.expectedpr-review/tests/marker-cases/mixed-severity.mdpr-review/tests/marker-cases/pr-222-critical-issues-found.expectedpr-review/tests/marker-cases/pr-222-critical-issues-found.mdpr-review/tests/marker-cases/zero-count-low-tally.expectedpr-review/tests/marker-cases/zero-count-low-tally.mdpr-review/tests/marker-cases/zero-count-medium-tally.expectedpr-review/tests/marker-cases/zero-count-medium-tally.mdpr-review/tests/marker-cases/zero-count-tally-lines.expectedpr-review/tests/marker-cases/zero-count-tally-lines.mdpr-review/tests/run-marker-cases.shruntime/base/Dockerfileruntime/scripts/smoke-test.sh
💤 Files with no reviewable changes (26)
- pr-review/tests/marker-cases/mixed-severity.expected
- pr-review/tests/marker-cases/marker-missing.md
- pr-review/tests/marker-cases/marker-malformed.expected
- pr-review/tests/marker-cases/marker-missing.expected
- pr-review/tests/marker-cases/zero-count-medium-tally.expected
- pr-review/tests/run-marker-cases.sh
- examples/claude-pr-review.yml
- pr-review/tests/marker-cases/clean-review.md
- pr-review/tests/marker-cases/zero-count-low-tally.expected
- pr-review/README.md
- pr-review/tests/marker-cases/zero-count-tally-lines.expected
- pr-review/tests/marker-cases/pr-222-critical-issues-found.expected
- pr-review/lib/parse-marker.sh
- pr-review/tests/marker-cases/zero-count-low-tally.md
- pr-review/tests/marker-cases/zero-count-tally-lines.md
- examples/README.md
- .github/workflows/claude-pr-review.yml
- pr-review/tests/marker-cases/clean-review.expected
- pr-review/tests/marker-cases/pr-222-critical-issues-found.md
- pr-review/tests/marker-cases/mixed-severity.md
- .github/workflows/test.yml
- .github/workflows/marker-emission-aggregate.yml
- pr-review/lib/severity-regex.sh
- pr-review/action.yml
- pr-review/tests/marker-cases/marker-malformed.md
- pr-review/tests/marker-cases/zero-count-medium-tally.md
…t PR - overlay-smoke.yml: scope the digest-lookup grep to claude-*.yml only (matches this repo's documented convention) and fail loudly with a clear error when multiple distinct digest pins are found for the same overlay, instead of silently picking one via `sort -u | head -n1`. - docs/consumer-onboarding.md: scope the Step 5 smoke checklist to the event-driven templates and add a separate manual-dispatch verification step for claude-apply-fix.yml, which cannot produce a PR-timeline comment. - README.md: drop the three remaining pr-review references in the "Migrating from v1 to v2" section now that pr-review/claude-pr-review.yml no longer exist. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e8950097a5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| ### Event-driven templates | ||
|
|
||
| Use this checklist for `claude-tag-respond.yml`, `claude-lint-failure.yml`, and `claude-ci-failure.yml`. It does not apply to the manually dispatched `claude-apply-fix.yml` template. |
There was a problem hiding this comment.
This newly broadened checklist still describes the old PR-review smoke path, but the three templates named here do not all run from simply opening a tiny PR: claude-tag-respond.yml waits for an @claude comment event, claude-lint-failure.yml only invokes Claude when its lint job fails, and claude-ci-failure.yml waits for a failed workflow_run. New consumers following these steps will get no Claude comment and be sent to troubleshooting even when their setup is correct, so the smoke instructions should be split by template with the actual trigger to fire.
Useful? React with 👍 / 👎.
1 participant
Summary
pr-review/composite action,.github/workflows/claude-pr-review.yml, its example caller, and the now-deadmarker-emission-aggregate.yml) now that all 4 known consumers (rsl-siege-manager, rsl-mom-bot, job-matcher, claude-configs) have migrated to CodeRabbit.runtime-build.yml/runtime-rollback.yml(5→4 workflows, 7→6 occurrences), and thetest.ymlmarker-corpus job that pointed at a deleted script.CLAUDE.md,README.md,docs/consumer-onboarding.md,examples/README.md, and stale comments inruntime/base/Dockerfile/runtime/scripts/smoke-test.sh/overlay-smoke.yml.@claude reviewtag-comment feature (claude-command-router→claude-runtime-reviewoverlay →claude-tag-respond.yml) is untouched and remains fully functional — verified viagit diffagainstruntime/ci-manifest.yaml,runtime/overlays/review/**,claude-command-router/**, andclaude-tag-respond.yml(all empty).Closes #309
Test plan
actionlintclean across the full workflow setclaude-command-router/tests/run-cases.sh— 40/40 passed (unchanged)pr-review/claude-pr-reviewconfirms no orphaned references outside intentionally-preserved historical docs and the surviving review-overlay path🤖 Generated by Claude Code on behalf of @cbeaulieu-gt
Summary by CodeRabbit
Removed Features
Documentation
CI and Maintenance