Skip to content

feat(form-migration): Enhance migration command with new option and skip orphan forms #19915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cedric-anne merged 3 commits into from
Jun 17, 2025
Merged

feat(form-migration): Enhance migration command with new option and skip orphan forms #19915

cedric-anne merged 3 commits into from
Jun 17, 2025

Conversation

@ccailly
Copy link
Member

@ccailly ccailly commented Jun 5, 2025 •
edited
Loading

Checklist before requesting a review

Please delete options that are not relevant.

  • I have read the CONTRIBUTING document.
  • I have performed a self-review of my code.
  • I have added tests that prove my fix is effective or that my feature works.

Description

Improvements to the form migration script:

  • No longer import “orphaned” forms that do not have a valid entity
  • Addition of an option to import specific forms by specifying their ID
  • Removal of unnecessary errors for the end user

@ccailly ccailly force-pushed the feature/form-migration-add-options branch 3 times, most recently from d7998a9 to cf7f82e Compare June 11, 2025 13:21
@ccailly ccailly force-pushed the feature/form-migration-add-options branch from cf7f82e to 2094eca Compare June 11, 2025 13:28
@ccailly ccailly changed the title feat(form-migration): Enhance migration command with new options feat(form-migration): Enhance migration command with new option and skip orphan forms Jun 11, 2025
@ccailly ccailly marked this pull request as ready for review June 11, 2025 14:41
@ccailly ccailly requested review from cedric-anne and trasher June 11, 2025 14:41
cedric-anne
cedric-anne requested changes Jun 12, 2025
View reviewed changes
ccailly and others added 2 commits June 12, 2025 14:51
@ccailly @cedric-anne
Apply suggestions from code review
2043c34 
Co-authored-by: Cédric Anne <cedric.anne@gmail.com>
@ccailly
fix: PHP lint
c1e6915
@ccailly ccailly requested a review from cedric-anne June 16, 2025 12:07
@cedric-anne cedric-anne added this to the 11.1.0 milestone Jun 17, 2025
@cedric-anne cedric-anne merged commit 528560c into glpi-project:main Jun 17, 2025
6 of 7 checks passed
@mathaym25 mathaym25 mentioned this pull request Jun 18, 2025
Closed
2 tasks
@ccailly ccailly mentioned this pull request Jun 19, 2025
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@trasher trasher trasher approved these changes

@cedric-anne cedric-anne cedric-anne approved these changes

Assignees

No one assigned

Labels

forms

Projects

None yet

Milestone

12.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@ccailly @trasher @cedric-anne