Fix KB article missing scroll in edit mode#23954
Merged
cedric-anne merged 1 commit intoglpi-project:mainfrom Apr 20, 2026
Merged
Fix KB article missing scroll in edit mode#23954cedric-anne merged 1 commit intoglpi-project:mainfrom
cedric-anne merged 1 commit intoglpi-project:mainfrom
Conversation
AdrienClairembault
force-pushed
the
fix-kb-edit-scroll
branch
from
a3125b9 to
aff6b2c
Compare
cedric-anne
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When entering edit mode, the KB container was expanding over his defined max height, which de-synchronized it from the side bar (see the blank space at the bottom right corner in the image below):
It turns out to be caused by some css instructions that were meant to deal with the bubble menu overflow.
After removing them, the menu was out of sync with its target element after a scroll so I had to do a few more tweaks (mainly attaching it the KB container so it scrolls with it, previously it was attached to the top level body tag).