fix: handle GlycoCT alditol residues - #22
Merged
Merged
Conversation
Up to standards ✅🟢 Issues
|
fubin1999
marked this pull request as ready for review
June 30, 2026 10:38
Member
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds GlycoCT alditol support to
parse_glycoct()by normalizing open-chain alditol residues to regular reducing-end glycans with unknown anomer configurations.Details
o-...-0:0|1:aldimonosaccharides.glyrepr::get_anomer_pos()to return unknown reducing-end anomers such as?1forGlcNAc-ol.GlcNAc-ol, a linked alditol glycan, and all distinct converter-derived alditol descriptors available from the local converter.parse_glycoct()documentation and adds a development NEWS entry for fix: handle GlycoCT alditol residues #22.Verification
Rscript -e 'devtools::document()'-> updatedparse_glycoct.RdRscript -e 'devtools::test(filter = "parse-glycoct")'-> 298 passedair format R/parse-glycoct.R tests/testthat/test-parse-glycoct.RRscript -e 'devtools::test()'-> 922 passedgit diff --check-> clean