feat: add curl installer for macOS and Linux - #96
Merged
Conversation
install.sh wraps uv rather than downloading a binary, since glyf ships as a Python package: it installs uv when missing, runs uv tool install glyf-core, and reports the PATH line to add when uv's bin directory is not on PATH. Supports --update, --version, and --no-uv-install; never uses sudo. Hosted from raw.githubusercontent.com rather than the docs domain, which is behind Cloudflare Access during the beta. Refs kannandreams/glyf-for-dummies#8.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking issue
Approach
glyfis a Python package, not a static binary, soinstall.shwrapsuvinstead of downloading and checksumming a tarball the waytuff/install.shdoes. It detects the platform, installsuvif missing (official Astral installer), runsuv tool install glyf-core, then verifies by executing the installedglyf --version.sh,set -eu, shellcheck clean. Nosudoanywhere — everything lands in uv's tool directory.--updateupgrades, falling back to a plain install when nothing is installed yet.--version Xpins (with--force, so it also works as a downgrade).--no-uv-installrefuses to installuvfor you.--helpdocuments all of it.GLYF_INSTALL_DIRandUV_TOOL_BIN_DIRare honoured.PATH, it prints theexport PATH=...line and mentionsuv tool update-shell, rather than editing rc files itself.Hosting: raw.githubusercontent.com, not the docs domain
The issue proposed
https://glyf.pages.dev/install.sh, but that domain sits behind Cloudflare Access during the beta, so an anonymouscurlgets a login page rather than the script. The canonical URL is therefore the raw file onmain. When the docs site opens to the public, add the docs-domain copy and switch the documented URL.Verification
Exercised locally against a sandboxed
UV_TOOL_DIR/UV_TOOL_BIN_DIR: fresh install from PyPI, re-run (idempotent),--update,--version 0.3.0,--version=0.3.0,GLYF_INSTALL_DIR, unknown-option rejection, missing-value rejection, and the--no-uv-installrefusal path withuvstripped fromPATH. Every one behaved as intended andglyf --versionreportedglyf 0.3.0.New
installer.ymlkeeps it honest: shellcheck plus a real install onubuntu-latest,ubuntu-24.04-arm, andmacos-15. The runners have nouv, so CI exercises the bootstrap path a first-time user actually hits, then re-runs for idempotence, upgrades, pins an exact version, and asserts an unknown option is rejected.Docs
Install script section on the docs-site installation page (including how to read the script before running it), a short block in the README, and a line in
llms.txt.