Fix rawLine: and offsetOfRawLine:#589
Merged
gnachman merged 1 commit intognachman:masterfrom Feb 24, 2026
Merged
Conversation
…ne drops Both methods hardcoded linenum == 0 → start = 0 instead of checking linenum == _firstEntry → start = bufferStartOffset. After dropLines advances _firstEntry and sets bufferStartOffset to a non-zero value, they returned a pointer/offset that started too early in the buffer, reading dropped data and missing the tail of live data. The fix mirrors the existing correct logic in _lineRawOffset: and lengthOfRawLine:.
Owner
|
Good catch! |
eyupcanakman
pushed a commit
to eyupcanakman/iTerm2
that referenced
this pull request
Mar 1, 2026
…ne drops (gnachman#589) Both methods hardcoded linenum == 0 → start = 0 instead of checking linenum == _firstEntry → start = bufferStartOffset. After dropLines advances _firstEntry and sets bufferStartOffset to a non-zero value, they returned a pointer/offset that started too early in the buffer, reading dropped data and missing the tail of live data. The fix mirrors the existing correct logic in _lineRawOffset: and lengthOfRawLine:. Co-authored-by: chall37 <chall37@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fix mirrors the existing correct logic in _lineRawOffset: and lengthOfRawLine: corrected in 05d178c.