fix(web): add missing st7/f9/package i18n keys from landing .ipk update - #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #26
What
The landing theater step 07 (heading + paragraph) and the
.ipkhero chip / feature card rendered the raw i18n keys (theater.st7t,theater.st7p,facts.package,features.f9t,features.f9p) in every language, because those keys were never added to the dicts.Changes
web/i18n.js: added the 5 missing keys to the EN and ES dict blocks (other 8 languages fall back to EN viat()).Verification
data-i18nkeys used inweb/index.htmlnow resolve (no raw-key fallback).node --checksyntax OK.https://netpulse.cloudless.clubconfirms step 07 renders correctly in ES and EN (no raw keys).