This repository was archived by the owner on Feb 18, 2020. It is now read-only.
Feature/wallet - separation of Header Components#5
Merged
W3stside merged 18 commits intocomponentsfrom Oct 26, 2017
Merged
Conversation
…o smart container - unrelated: deleted truffleTest.js as unused
…t to MenuWallet + path names
… claim tokens, changed _navbar.scss td color to black, fixed general syntax bugs - running in Storybook
…es in Storybook + Localhost
…Hamburger nav menu. Added show, hide classes on click in new Hamburger class w/internal state
…dded an extra div in the header > div > nav styling chain due to the necessary wrapping of the Hamburger.tsx component - TS typing does not support React 16 rendering completely yet
…r + broken in isolation (sidebar breaks)
…ated components inserted - removed unnecessary path sections in import files
…ad tags, respectively. Linting
Velenir
reviewed
Oct 26, 2017
| } | ||
|
|
||
| export default class Hamburger extends Component<HamburgerProps, HamburgerState> { | ||
| constructor(props: HamburgerProps) { |
Contributor
There was a problem hiding this comment.
It is mostly a matter of taste, but a shorter alternative would be to use class props:
state = { isOpen: false}
handleClick = () => this.State({ isOpen: !this.state.isOpen })
and no need for constructor
| {/* Wallet Info - Address && Balance */} | ||
| <span> | ||
| <code>{`${account ? account.slice(0,14) : 'loading...'}...`}</code> | ||
| <small>{balance ? balance : 'loading...'} ETH</small> |
Contributor
There was a problem hiding this comment.
it'll display loading... when balance === 0
| separator: any | ||
| ) => ({ | ||
| name: text('title', name), | ||
| ongoingAuctions: array('Ongoing Auctions', auctionsArr, separator) |
Contributor
There was a problem hiding this comment.
ongoingAuctions knob displays [Object] as it JSON.stringifies it like that
storybook-knobs don't allow to edit array of objects easily
a workaround would be to add a knob for each auction:
ongoingAuctions: auctionsArr.map((auction, i) => object(`Ongoing Auction ${i}`, auction)),
also would be nice to have more auctions, even randomly generated
…0 as 0 was falsy and return 'loading' incorrectly
…r instead of <tr> || removed unused import in Header || added random auctions for stories/MenuAuction || linting
Velenir
approved these changes
Oct 26, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Separated Header into 4 components