CI: check out and cache with Node 24 actions - #408
Merged
Conversation
Every job logs "Node.js 20 is deprecated" and runs actions/checkout@v3 on Node 24 anyway, because the runners no longer have Node 20. The releases that declare node24 in their action.yml are checkout v5, upload-artifact v6 and cache v5. msys2/setup-msys2@v2 and reactivecircus/android-emulator-runner@v2 already declare node24. checkout v5 needs a runner of 2.327.1 or later; the hosted runners are on 2.336.0. v6 moves credentials to a separate file and v7 refuses a fork checkout for pull_request_target and workflow_run, neither of which these workflows use.
Contributor
Author
|
Needs #407 merged first. |
davidchisnall
approved these changes
Aug 8, 2026
davidchisnall
left a comment
davidchisnall
left a comment
Member
There was a problem hiding this comment.
Looks good, but conflicts with the change in the other fix.
# Conflicts: # .github/workflows/main.yml
Contributor
Author
|
rebased on #407 and conflicts resolved - ready to merge. |
Member
|
GitHub disagrees: This branch cannot be rebased due to conflicts. |
Contributor
Author
|
GitHub is being difficult then... this is what I see: |
Member
|
Oh, it looks like you did a merge not a rebase, rebase-and-merge doesn't like it because it breaks linear history. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every job logs "Node.js 20 is deprecated" and then runs actions/checkout@v3 on
Node 24 anyway, because the runners no longer carry Node 20.
The releases whose action.yml declares node24 are checkout v5, upload-artifact
v6 and cache v5, so those are the versions used here. msys2/setup-msys2@v2 and
reactivecircus/android-emulator-runner@v2 already declare node24 and are
unchanged. checkout v5 wants a runner of 2.327.1 or later and the hosted
runners are on 2.336.0. v6 moves credentials to a separate file and v7 refuses
a fork checkout for pull_request_target and workflow_run, and neither event is
used by these workflows.
Verified on a run of this branch: no job logs the deprecation, and the logs
carry checkout v5, upload-artifact v6 and cache v5. The windows jobs still fail
on this branch for the reason PR 407 fixes; on a branch carrying both changes
they pass.