Skip to content

fix test_default error message #28#29

Merged
VojtechVitek merged 1 commit into
go-chi:masterfrom
ablankz:fix/test-default-msg_#28
May 4, 2024
Merged

fix test_default error message #28#29
VojtechVitek merged 1 commit into
go-chi:masterfrom
ablankz:fix/test-default-msg_#28

Conversation

@ablankz

@ablankz ablankz commented May 3, 2024

Copy link
Copy Markdown
Contributor

The following parts of the TestDefault function have been corrected.

if s.allowedHeaders == nil {
-    t.Error("c.allowedHeaders should be nil when Default")
+    t.Error("c.allowedHeaders must not be nil when Default")
}
if s.allowedMethods == nil {
-    t.Error("c.allowedMethods should be nil when Default")
+    t.Error("c.allowedMethods must not be nil when Default")
}

@VojtechVitek VojtechVitek left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks :)

@VojtechVitek

Copy link
Copy Markdown
Contributor

Unrelated test failure. Merging.

@VojtechVitek VojtechVitek merged commit b41f767 into go-chi:master May 4, 2024
@VojtechVitek

Copy link
Copy Markdown
Contributor

Fixed in #32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants