Embedded images not displayed in review comments

[adrian17]

• Gitea version (or commit ref): 1.12.0+dev-331-g21e771c41
• Git version: -
• Operating system: -
• Database (use [x]):
  • PostgreSQL
  • MySQL
  • MSSQL
  • SQLite
• Can you reproduce the bug at https://try.gitea.io:
  • Yes: https://try.gitea.io/testacc1777/test-pr-with-branch-good/pulls/1
  • No
  • Not relevant

Description

The review editor allows embedding images; however, when I submit the review, the image doesn't actually appear in the review window.

Screenshots

[adrian17]

That's not a proposal, that's a bug. The review editor has a button that explicitly says "insert image", but after using it, the review doesn't actually have any image inserted; there's just raw markdown instead.

[lafriks]

Yeah but that'd tricky one to display in current ui

[alexanderadam]

Isn't a tricky bug still a bug? 🤔

[zeripath]

The answer is then surely to just remove the insert image button ?

[fnetX]

This issue is probably about the fact, that the upload URL is not known before creating the issue? If it's not possible to upload the images immediately like GitHub does or reserving an ID for them, why not use a placeholder, like inserting an image as

![](userupload_1)

and replacing the URL upon saving.

[fnetX]

Guys, adding images works fine, but the URL in the OP is not an image but this Wikipedia hashtag when you open that popover view. I think there is no bug here (and my last comment is offtopic and for another matter that was most likely linked by mistake: https://codeberg.org/Codeberg/Community/issues/9#issuecomment-49466 )

@adrian17 can you confirm that this works just fine if you use the actual image url https://upload.wikimedia.org/wikipedia/commons/b/b8/Ipod_linux_booting_kernel.jpg instead?

[wxiaoguang]

The review editor could support images. Feel free to reopen if there is a problem.