Create webhook with gitea api and get RequiredError

[Sylor-huang]

My environments are Rails and Mysql and Gitea

Gitea create webhook api :

# api 

/repos/{owner}/{repo}/hooks

# params: 

{
  "active": false,
  "branch_filter": "string",
  "config": {
    "additionalProp1": "string",
    "additionalProp2": "string",
    "additionalProp3": "string"
  },
  "events": [
    "string"
  ],
  "type": "dingtalk"
}

When I use this api to create webhook with custom params

I get errors which say RequiredError

# custom params: 

hook_params = {
      active: true,
      branch_filter: "*",
      config: {
        content_type: "application/json",
        url: "xx/repositories/2222/repo_hooks.json",
        http_method: "post"
      },
      events: ["create", "pull", "push"],
      type: "gitea",
    }

Response Errors Logs

...

I, [2020-05-12T10:19:32.254166 #86437]  INFO -- request: POST xxxx/api/v1/repos/ownner/repo_name/hooks
D, [2020-05-12T10:19:32.254238 #86437] DEBUG -- request: Content-Type: "application/json"
...
User-Agent: "Faraday v0.15.4"
I, [2020-05-12T10:19:32.698568 #86437]  INFO -- response: Status 422
D, [2020-05-12T10:19:32.698731 #86437] DEBUG -- response: server: "nginx/1.10.1"
date: "Tue, 12 May 2020 02:19:32 GMT"
content-type: "application/json; charset=utf-8"
content-length: "159"
connection: "close"
...
###############____response__#<Faraday::Response:0x00007f942fcd7330>
###############____response_status_422
###############____response_body_[{"fieldNames":["Type"],"classification":"RequiredError","message":"Required"},{"fieldNames":["Config"],"classification":"RequiredError","message":"Required"}]
...

I had changed hook_params.type to hook_params.Type, and the same to hook_params.Config, but it seems do not work also.

Is my hook_params wrong? and how to fix hook_params?
TKS~

[Jaskaranbir]

A few potential causes for problems:

• Malformed JSON. That doesnt look like valid JSON which you posted in first snippet. But I am guessing its being converted to one before being sent-off.
• Content-Type header mismatch. Ensure that the Content-Type header is present and has value application/json. I made this mistake where my header was application/x-www-url-form-encoded, and it took me longer than it should have to realize that.
• I noticed that in your payload, under config.content_type, you have application/json. That refers to content_type of Webhook, not your request. The only valid content-types for Webhooks are json or form.

If it helps, you can try tracing the errors you get through source-code and checking the conditions which cause them. For example, here is where the possible Webhook-types are defined:

gitea/models/webhook.go

Lines 31 to 34 in 1dd3f19

	var hookContentTypes = map[string]HookContentType{
	"json": ContentTypeJSON,
	"form": ContentTypeForm,
	}

And if it helps, here's a sample curl-request which should work:

curl --location --request POST 'http://git-tea-host/api/v1/repos/test-user/test-repo/hooks' \
--header 'Content-Type: application/json' \
--header 'Authorization: Basic <someBase64Str>' \
--header 'Content-Type: application/json' \
--data-raw '{
  "active": true,
  "branch_filter": "*",
  "config": {
    "content_type": "json",
    "url": "http://repositories/2222",
    "http_method": "post"
  },
  "events": [
    "push_only"
  ],
  "type": "gitea"
}'

[Sylor-huang]

@Jaskaranbir Thanks very much , I will try it later, whether it work or not , I will replay.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. I am here to help clear issues left open even if solved or waiting for more insight. This issue will be closed if no further activity occurs during the next 2 weeks. If the issue is still valid just add a comment to keep it alive. Thank you for your contributions.

[stale]

This issue has been automatically closed because of inactivity. You can re-open it if needed.