GitHub migration exceeds API rate limit

[davidak]

• Gitea version (or commit ref): 1.13.0+rc1
• Git version: 2.20.1
• Operating system: debian stable 10.6
• Database (use [x]):
  • PostgreSQL
  • MySQL
  • MSSQL
  • SQLite
• Can you reproduce the bug at https://try.gitea.io:
  • Yes (provide example URL)
  • No
  • i get migration failed too, but can't look into your logs ;)

Description

That should not happen. It should rather wait and inform the user, so the migration does not fail.

Related to #13241 and #13242

[stale]

This issue has been automatically marked as stale because it has not had recent activity. I am here to help clear issues left open even if solved or waiting for more insight. This issue will be closed if no further activity occurs during the next 2 weeks. If the issue is still valid just add a comment to keep it alive. Thank you for your contributions.

[lunny]

The problem will occur when you finished a migration and start another. On that situation, we haven't know if it's exceeds API rate limit.

[zeripath]

Maybe we should cache the github limit per user? We can even set the TTL to simply be the timeout.

[lunny]

We can try. And also when start two or more migrations per Github User, I think it also maybe failed.

[lafriks]

Doesn't github returns current rate limit in headers?

[lunny]

Doesn't github returns current rate limit in headers?

If only one thread to do that, the returned current rate limit is meaningful. But when two or more threads requests github at the same time, it will not be useful.

[6543]

look's like switching to GraphQL API will give us more requests per limit:
git-bug/git-bug#315 (comment)