Fix different behavior in status check pattern matching with double stars #35474
+325
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
wxiaoguang
force-pushed
the
fix-glob-match
branch
2 times, most recently
from
1fab533 to
d445b67
Compare
wxiaoguang
force-pushed
the
fix-glob-match
branch
from
d445b67 to
3a663c4
Compare
lunny
approved these changes
Sep 12, 2025
GiteaBot
added
lgtm/need 1
hiifong
approved these changes
Sep 13, 2025
GiteaBot
added
lgtm/done
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Sep 13, 2025
* giteaofficial/main: Fix different behavior in status check pattern matching with double stars (go-gitea#35474) Replace webpack with rspack (go-gitea#35460) Don't store repo archives on `gitea dump` (go-gitea#35467) Fix SSH signing key path will be displayed in the pull request UI (go-gitea#35381) [skip ci] Updated translations via Crowdin Update image name in integration README (go-gitea#35465)
|
FYI: https://github.com/go-gitea/gitea/security/code-scanning/144, maybe a false-positive. It seems most of these code scanning results are bogus. |
False-positive. That code is only used for the special test data from Golang |
To fix: fd02f8b |
silverwind
added a commit
to ChristopherHX/gitea
that referenced
this pull request
Sep 16, 2025
* origin/main: Clean up npm dependencies (go-gitea#35484) Update eslint to v9 (go-gitea#35485) Revert the rspack change (go-gitea#35482) Replace gobwas/glob package (go-gitea#35478) Fix various typos in codebase (go-gitea#35480) Fix different behavior in status check pattern matching with double stars (go-gitea#35474) Replace webpack with rspack (go-gitea#35460) Don't store repo archives on `gitea dump` (go-gitea#35467)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop the minimatch dependency, use our own glob compiler.
Fix #35473