Skip to content

Fix cli "Before" handling (#35797) #35808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 31, 2025
Merged

Fix cli "Before" handling (#35797) #35808

merged 1 commit into from
Oct 31, 2025
+55 −16

Conversation

@GiteaBot
Copy link
Collaborator

@GiteaBot GiteaBot commented Oct 31, 2025

Backport #35797 by @wxiaoguang

Regression of #34973

Fix #35796

@GiteaBot GiteaBot added issue/regression Indicates a previously functioning feature or behavior that has broken or regressed after a change modifies/cli PR changes something on the CLI, i.e. gitea doctor or gitea admin modifies/go Pull requests that update Go code type/bug labels Oct 31, 2025
@GiteaBot GiteaBot added this to the 1.25.1 milestone Oct 31, 2025
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 31, 2025
@GiteaBot GiteaBot requested review from TheFox0x7 and lunny October 31, 2025 18:12
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 31, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 31, 2025
@silverwind silverwind merged commit fddf6cd into go-gitea:release/v1.25 Oct 31, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lunny lunny lunny approved these changes

+1 more reviewer

@TheFox0x7 TheFox0x7 TheFox0x7 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@wxiaoguang wxiaoguang

Labels

issue/regression Indicates a previously functioning feature or behavior that has broken or regressed after a change lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/cli PR changes something on the CLI, i.e. gitea doctor or gitea admin modifies/go Pull requests that update Go code type/bug

Projects

None yet

Milestone

1.25.1

Development

Successfully merging this pull request may close these issues.

5 participants

@GiteaBot @lunny @TheFox0x7 @silverwind @wxiaoguang