Skip to content

Fix cli "Before" handling #35797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 31, 2025
Merged

Fix cli "Before" handling #35797

merged 5 commits into from
Oct 31, 2025
+55 −16

Conversation

@wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Oct 30, 2025 •
edited
Loading

Regression of #34973

Fix #35796

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 30, 2025
@github-actions github-actions bot added modifies/go Pull requests that update Go code modifies/cli PR changes something on the CLI, i.e. gitea doctor or gitea admin labels Oct 30, 2025
@wxiaoguang wxiaoguang requested a review from TheFox0x7 October 30, 2025 23:13
@wxiaoguang wxiaoguang mentioned this pull request Oct 30, 2025
Closed
@wxiaoguang wxiaoguang added type/bug issue/regression Indicates a previously functioning feature or behavior that has broken or regressed after a change backport/v1.25 labels Oct 30, 2025
TheFox0x7
TheFox0x7 approved these changes Oct 30, 2025
View reviewed changes
Copy link
Contributor

@TheFox0x7 TheFox0x7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The order was incorrect I take it?

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 30, 2025
@wxiaoguang
Copy link
Contributor Author

wxiaoguang commented Oct 30, 2025

The order was incorrect I take it?

It seems so, I added more tests and comments

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 31, 2025
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Oct 31, 2025
@lunny lunny enabled auto-merge (squash) October 31, 2025 17:42
@lunny lunny merged commit de70cd3 into go-gitea:main Oct 31, 2025
26 checks passed
@GiteaBot GiteaBot added this to the 1.26.0 milestone Oct 31, 2025
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Oct 31, 2025
@wxiaoguang @GiteaBot
Fix cli "Before" handling (go-gitea#35797)
ff159e9 
Regression of go-gitea#34973

Fix go-gitea#35796
@GiteaBot GiteaBot mentioned this pull request Oct 31, 2025
Merged
@GiteaBot GiteaBot added backport/done All backports for this PR have been created and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Oct 31, 2025
silverwind pushed a commit that referenced this pull request Oct 31, 2025
@GiteaBot @wxiaoguang
Fix cli "Before" handling (#35797) (#35808)
fddf6cd 
Backport #35797 by @wxiaoguang

Regression of #34973

Fix #35796

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
@wxiaoguang wxiaoguang deleted the fix-cli-before branch November 1, 2025 02:50
zjjhot added a commit to zjjhot/gitea that referenced this pull request Nov 3, 2025
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
df5ab5b 
* giteaofficial/main:
  Add cache to container build (go-gitea#35697)
  Revert gomail to v0.7.0 to fix sending mail failed (go-gitea#35816)
  Fix circular spin animation direction (go-gitea#35785)
  Fix clone mixed bug (go-gitea#35810)
  [skip ci] Updated translations via Crowdin
  Remove unnecessary function parameter (go-gitea#35765)
  Fix cli "Before" handling (go-gitea#35797)
  Add test for ExtendCommentTreePathLength migration and fix bugs (go-gitea#35791)
  Fix file extension on gogs.png (go-gitea#35793)
  Improve and fix markup code preview rendering (go-gitea#35777)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lunny lunny lunny approved these changes

+1 more reviewer

@TheFox0x7 TheFox0x7 TheFox0x7 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport/done All backports for this PR have been created backport/v1.25 issue/regression Indicates a previously functioning feature or behavior that has broken or regressed after a change lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/cli PR changes something on the CLI, i.e. gitea doctor or gitea admin modifies/go Pull requests that update Go code type/bug

Projects

None yet

Milestone

1.26.0

Development

Successfully merging this pull request may close these issues.

Git pull/push is hanging in 1.25.0 (fixed in 1.25 nightly and will be released as 1.25.1)

4 participants

@wxiaoguang @lunny @TheFox0x7 @GiteaBot