Skip to content

Conversation

@lunny
Copy link
Member

@lunny lunny commented Nov 3, 2025

Fix #35803
Backport #35821

…a#35821)

Fix go-gitea#35803

---------

Signed-off-by: silverwind <me@silverwind.io>
Co-authored-by: silverwind <me@silverwind.io>
@GiteaBot GiteaBot added this to the 1.25.1 milestone Nov 3, 2025
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 3, 2025
@github-actions github-actions bot added modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files labels Nov 3, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 3, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 3, 2025
@lunny lunny merged commit 8116742 into go-gitea:release/v1.25 Nov 4, 2025
26 checks passed
@lunny lunny deleted the lunny/fix_pr_viewed_files_number2 branch November 4, 2025 01:19
@wxiaoguang
Copy link
Contributor

I don't think the fix is complete (not sure whether it is right)

For example, when there is "load more", this countAndUpdateViewedFiles still makes incorrect count.

image

@lunny
Copy link
Member Author

lunny commented Nov 4, 2025

I don't think the fix is complete (not sure whether it is right)

For example, when there is "load more", this countAndUpdateViewedFiles still makes incorrect count.

image

You are right. When there are two load more, it will be wrong. I just manually tested one load more.

@lunny lunny mentioned this pull request Nov 4, 2025
lunny added a commit that referenced this pull request Nov 4, 2025
Follow #35821
Fix #35844 (comment)

The reviewed file numbers and progress have been set from backend so
that we don't need to update the numbers when clicking `load more`.
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Nov 4, 2025
Follow go-gitea#35821
Fix go-gitea#35844 (comment)

The reviewed file numbers and progress have been set from backend so
that we don't need to update the numbers when clicking `load more`.
lafriks pushed a commit that referenced this pull request Nov 4, 2025
Backport #35846 by @lunny

Follow #35821
Fix #35844 (comment)

The reviewed file numbers and progress have been set from backend so
that we don't need to update the numbers when clicking `load more`.

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants