Skip to content

Fix viewed files number is not right if not all files loaded #35821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 3, 2025
Merged

Fix viewed files number is not right if not all files loaded #35821

merged 6 commits into from
Nov 3, 2025
+24 −8

Conversation

@lunny
Copy link
Member

@lunny lunny commented Nov 2, 2025

Fix #35803

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 2, 2025
@github-actions github-actions bot added modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files labels Nov 2, 2025
silverwind
silverwind reviewed Nov 3, 2025
View reviewed changes
silverwind
silverwind reviewed Nov 3, 2025
View reviewed changes
@silverwind
Update models/pull/review_state.go
43cf124 
Signed-off-by: silverwind <me@silverwind.io>
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 3, 2025
@lunny lunny mentioned this pull request Nov 3, 2025
Open
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 3, 2025
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Nov 3, 2025
@lunny lunny merged commit de26c8a into go-gitea:main Nov 3, 2025
25 checks passed
@GiteaBot GiteaBot added this to the 1.26.0 milestone Nov 3, 2025
@lunny lunny deleted the lunny/fix_pr_viewed_files_number branch November 3, 2025 21:34
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Nov 3, 2025
lunny added a commit to lunny/gitea that referenced this pull request Nov 3, 2025
@lunny @silverwind
Fix viewed files number is not right if not all files loaded (go-gite…
62ffc28 
…a#35821)

Fix go-gitea#35803

---------

Signed-off-by: silverwind <me@silverwind.io>
Co-authored-by: silverwind <me@silverwind.io>
@lunny lunny mentioned this pull request Nov 3, 2025
Merged
lunny added a commit that referenced this pull request Nov 4, 2025
@lunny @silverwind
Fix viewed files number is not right if not all files loaded (#35821) (…
8116742 
…#35844)

Fix #35803
Backport #35821

Signed-off-by: silverwind <me@silverwind.io>
Co-authored-by: silverwind <me@silverwind.io>
@lunny lunny added the backport/done All backports for this PR have been created label Nov 4, 2025
@lunny lunny mentioned this pull request Nov 4, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@silverwind silverwind silverwind approved these changes

+1 more reviewer

@Zettat123 Zettat123 Zettat123 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport/done All backports for this PR have been created backport/v1.25 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files type/bug

Projects

None yet

Milestone

1.26.0

Development

Successfully merging this pull request may close these issues.

Incorrect viewed files counter in huge PRs

4 participants

@lunny @silverwind @Zettat123 @GiteaBot