Error when pushing docker image to a repo

[avee87]

Description

Gitea throws a panic error every time I try to push a Docker image to a repo.

This seems to only be affecting 1.25.2 because reverting Gitea to 1.25.1 fixed the issue.

Observing error with the following Docker image version:
gitea/gitea:1.25.2@sha256:534428e78fc00d3ac8647f3467a3f91252acf23a46ea0c872f03191e3c878f7d
No error when using
gitea/gitea:1.25.1@sha256:b3aee0f6fa4ff3271180a2388bb796be5cced8828685b968a310d70e881fcbb3

2025/11/24 22:54:25 HTTPRequest [W] router: failed    PUT /v2/<user>/<repo>/manifests/<version>for<ip>:0, panic in 4.3ms @ container/container.go:558(container.PutManifest), err=runtime error: invalid memory address or nil pointer dereference
2025/11/24 22:54:25 routers/common/errpage.go:25:RenderPanicErrorPage() [E] PANIC: runtime error: invalid memory address or nil pointer dereference
/usr/local/go/src/runtime/panic.go:783 (0x4860b1)
/go/src/code.gitea.io/gitea/modules/web/routing/logger_manager.go:116 (0x1826344)
/usr/local/go/src/runtime/panic.go:783 (0x4860b1)
/usr/local/go/src/runtime/panic.go:262 (0x4887d8)
/usr/local/go/src/runtime/signal_unix.go:925 (0x4887a8)
/go/src/code.gitea.io/gitea/models/packages/descriptor.go:110 (0x190d85a)
/go/src/code.gitea.io/gitea/models/packages/descriptor.go:106 (0x190d7e4)
/go/src/code.gitea.io/gitea/routers/api/packages/container/manifest.go:91 (0x2897e44)
/go/src/code.gitea.io/gitea/routers/api/packages/container/manifest.go:228 (0x28988f1)
/go/src/code.gitea.io/gitea/routers/api/packages/container/manifest.go:72 (0x2897ad8)
/go/src/code.gitea.io/gitea/routers/api/packages/container/container.go:588 (0x2895509)
/usr/local/go/src/reflect/value.go:581 (0x51a685)
/usr/local/go/src/reflect/value.go:365 (0x519778)
/go/src/code.gitea.io/gitea/modules/web/handler.go:161 (0x182fa56)
/usr/local/go/src/net/http/server.go:2322 (0x9645e8)
/usr/local/go/src/net/http/server.go:2322 (0x9645e8)
/go/src/code.gitea.io/gitea/modules/web/handler.go:168 (0x182fac5)
/usr/local/go/src/net/http/server.go:2322 (0x9645e8)
/usr/local/go/src/net/http/server.go:2322 (0x9645e8)
/go/src/code.gitea.io/gitea/modules/web/handler.go:168 (0x182fac5)
/usr/local/go/src/net/http/server.go:2322 (0x9645e8)
/go/src/code.gitea.io/gitea/modules/web/router_path.go:34 (0x1832ae4)
/usr/local/go/src/reflect/value.go:581 (0x51a685)
/usr/local/go/src/reflect/value.go:365 (0x519778)
/go/src/code.gitea.io/gitea/modules/web/handler.go:161 (0x182fa56)
/usr/local/go/src/net/http/server.go:2322 (0x9645e8)
/usr/local/go/src/net/http/server.go:2322 (0x9645e8)
/go/src/code.gitea.io/gitea/modules/web/handler.go:168 (0x182fac5)
/usr/local/go/src/net/http/server.go:2322 (0x9645e8)
/go/src/code.gitea.io/gitea/modules/web/handler.go:168 (0x182fac5)
/usr/local/go/src/net/http/server.go:2322 (0x9645e8)
/go/src/code.gitea.io/gitea/modules/web/handler.go:168 (0x182fac5)
/usr/local/go/src/net/http/server.go:2322 (0x9645e8)
/go/src/code.gitea.io/gitea/modules/web/handler.go:168 (0x182fac5)
/usr/local/go/src/net/http/server.go:2322 (0x9645e8)
/go/pkg/mod/github.com/go-chi/chi/v5@v5.2.3/chain.go:31 (0x1826c25)
/go/pkg/mod/github.com/go-chi/chi/v5@v5.2.3/mux.go:477 (0x1829dbb)
/usr/local/go/src/net/http/server.go:2322 (0x9645e8)
/go/src/code.gitea.io/gitea/modules/web/handler.go:168 (0x182fac5)
/usr/local/go/src/net/http/server.go:2322 (0x9645e8)
/go/src/code.gitea.io/gitea/services/context/package.go:160 (0x1de6b91)
/usr/local/go/src/net/http/server.go:2322 (0x9645e8)
/go/src/code.gitea.io/gitea/modules/web/handler.go:125 (0x182ff15)
/usr/local/go/src/net/http/server.go:2322 (0x9645e8)
/go/pkg/mod/github.com/go-chi/chi/v5@v5.2.3/mux.go:73 (0x182784e)
/go/pkg/mod/github.com/go-chi/chi/v5@v5.2.3/mux.go:321 (0x18291ba)
/usr/local/go/src/net/http/server.go:2322 (0x9645e8)
/go/pkg/mod/github.com/go-chi/chi/v5@v5.2.3/mux.go:477 (0x1829dbb)
/usr/local/go/src/net/http/server.go:2322 (0x9645e8)
/go/src/code.gitea.io/gitea/modules/web/routing/logger_manager.go:122 (0x18261ce)
/usr/local/go/src/net/http/server.go:2322 (0x9645e8)
/go/src/code.gitea.io/gitea/modules/web/handler.go:125 (0x182ff15)
/usr/local/go/src/net/http/server.go:2322 (0x9645e8)
/go/pkg/mod/github.com/chi-middleware/proxy@v1.1.1/middleware.go:37 (0x29689af)
/usr/local/go/src/net/http/server.go:2322 (0x9645e8)
/go/src/code.gitea.io/gitea/modules/web/handler.go:125 (0x182ff15)
/usr/local/go/src/net/http/server.go:2322 (0x9645e8)
/go/src/code.gitea.io/gitea/routers/common/middleware.go:78 (0x296b194)
/usr/local/go/src/net/http/server.go:2322 (0x9645e8)
/go/src/code.gitea.io/gitea/modules/web/handler.go:125 (0x182ff15)
/usr/local/go/src/net/http/server.go:2322 (0x9645e8)
/go/src/code.gitea.io/gitea/routers/common/middleware.go:93 (0x296ad2f)
/usr/local/go/src/net/http/server.go:2322 (0x9645e8)
/go/src/code.gitea.io/gitea/modules/web/handler.go:125 (0x182ff15)
/usr/local/go/src/net/http/server.go:2322 (0x9645e8)
/go/pkg/mod/github.com/go-chi/chi/v5@v5.2.3/mux.go:90 (0x182780d)
/go/src/code.gitea.io/gitea/modules/web/router.go:243 (0x1831bc2)
/go/src/code.gitea.io/gitea/modules/web/router.go:181 (0x18315e6)
/usr/local/go/src/net/http/server.go:3340 (0x984e4d)
/usr/local/go/src/net/http/server.go:2109 (0x9626e4)
/usr/local/go/src/runtime/asm_amd64.s:1693 (0x48ea20)

Gitea Version

1.25.2

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

debian

How are you running Gitea?

docker

Database

PostgreSQL

[wxiaoguang]

Do you have reproducible steps?

I can see how to fix the panic, but I don't have idea why the "err" occurs (which causes the panic).

[wxiaoguang]

Or can you try this PR? Fix container registry error handling #36021 , or the simplest change is:

diff --git a/routers/api/packages/container/manifest.go b/routers/api/packages/container/manifest.go
index e408f6ee3b..30d591e60a 100644
--- a/routers/api/packages/container/manifest.go
+++ b/routers/api/packages/container/manifest.go
@@ -82,9 +82,11 @@ type processManifestTxRet struct {
 }
 
 func handleCreateManifestResult(ctx context.Context, err error, mci *manifestCreationInfo, contentStore *packages_module.ContentStore, txRet *processManifestTxRet) (string, error) {
-       if err != nil && txRet.created && txRet.pb != nil {
-               if err := contentStore.Delete(packages_module.BlobHash256Key(txRet.pb.HashSHA256)); err != nil {
-                       log.Error("Error deleting package blob from content store: %v", err)
+       if err != nil {
+               if txRet.created && txRet.pb != nil {
+                       if err := contentStore.Delete(packages_module.BlobHash256Key(txRet.pb.HashSHA256)); err != nil {
+                               log.Error("Error deleting package blob from content store: %v", err)
+                       }
                }
                return "", err
        }

[avee87]

Do you have reproducible steps?

Simplest repro for me is to create a Dockerfile with the following content:

FROM alpine  
CMD ["echo", "Hello World!!"]

Then run

docker build -t git.my.domain/myuser/hello-world:0.1.0 --platform linux/amd64 .
docker push git.my.domain/myuser/hello-world:0.1.0

Getting the following output on the client:

The push refers to repository [git.my.domain/myuser/hello-world]
13aee99bd38b: Pushed 
2d35ebdb57d9: Pushed 
failed commit on ref "index-sha256:c1521d00f4d6505a4a595331bf9f4b0c1756e24a0a506f31b590020885470ad5": unexpected status from PUT request to https://git.my.domain/v2/myuser/hello-world/manifests/0.1.0: 500 Internal Server Error

[wxiaoguang]

Strange, unable to reproduce even without #36021

And I also tried to switch buildkit by export DOCKER_BUILDKIT=0, still unable to reproduce

Could it be related to your docker's version?