Team permission to create repository in organization

[davidsvantesson]

Implements #5114.

• New team setting to allow team members to create repository in organization
• If a user that is not owner creates an repository in organization, he/she is automatically assigned as administrator (collaborator) on the new repo.

Screenshots

Team settings page:

[codecov-io]

Codecov Report

❗ No coverage uploaded for pull request base (master@35c3ea9). Click here to learn what that means.
The diff coverage is 55.95%.

@@            Coverage Diff            @@
##             master    #8312   +/-   ##
=========================================
  Coverage          ?   41.12%           
=========================================
  Files             ?      549           
  Lines             ?    71520           
  Branches          ?        0           
=========================================
  Hits              ?    29415           
  Misses            ?    38384           
  Partials          ?     3721

Impacted Files	Coverage Δ
modules/auth/org.go	0% <ø> (ø)
models/org_team.go	51.32% <ø> (ø)
models/migrations/migrations.go	1.3% <ø> (ø)
routers/org/teams.go	0% <0%> (ø)
models/migrations/v109.go	0% <0%> (ø)
models/repo.go	45.23% <10%> (ø)
routers/api/v1/org/team.go	40.07% <100%> (ø)
modules/convert/convert.go	79.2% <100%> (ø)
models/org.go	71.17% <100%> (ø)
routers/repo/repo.go	29.16% <40%> (ø)
... and 3 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35c3ea9...c5ead25. Read the comment docs.

[guillep2k]

LGTM - you need to fix the err:= assignments.

[davidsvantesson]

I added information to the team sidebar also (only shown if this permission is granted):

[lunny]

It's strange you can create a repository, but only have read access permission of that repository.
Maybe we should add a new permission between write access and admin access. I noticed github added serval new permissions.

Maybe we can named it Create Access, users will have Write Access with extra create a new one.

[davidsvantesson]

@lunny I agree you need permission to a repository you created. I would say you should even have admin access. I think it is just strange to be able to create a repository but not change its settings.

What I have done in this PR is to add the creator as admin collaborator if he is not owner. With teams with access to all repositories, that might not be necessary if user will be admin of repo anyhow.

[davidsvantesson]

GitHub has the concept of org members and outside collaborators. In Gitea currently all team members is also members of the organization. Access to repositories seem to be possible to set for a user / team regardless if they are member or not. All organization members can per default create repositories. It is not clear what access the creator of a repository has, but I suppose the creator gets admin access automatically?

[davidsvantesson]

@lunny It would be good with refined access levels (for teams and/or collaborators), but I don't think it affects this PR. What could maybe be done is to allow setting the minimum default access the creator of a repository should get.

[lunny]

So we need some hints on the create UI?

I suppose the creator gets admin access automatically?

[davidsvantesson]

I have merged with the add all repos feature (#8688). The creator now gets admin access unless get it automatically. If someone see need for it an option could be added what access the creator get, but I am not sure it makes much sense. Maybe write access could be enough if other settings are set up automatically (e.g. templates).

Updated screenshot:

[lunny]

needs @lafriks 's review.