Skip to content

Conversation

@6543
Copy link
Member

@6543 6543 commented Sep 5, 2020

close #12723

StopWatch

  • extend TestAPIListStopWatches
  • remove type Stopwatches

Commit:

  • create own file for related things in convert package
  • rename ToCommit ToPayloadCommit
  • move toCommit into convert package

@6543 6543 added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Sep 5, 2020
@techknowlogick techknowlogick added this to the 1.14.0 milestone Sep 5, 2020
@6543 6543 added the modifies/api This PR adds API routes or modifies them label Sep 5, 2020
@codecov-commenter
Copy link

codecov-commenter commented Sep 5, 2020

Codecov Report

Merging #12729 into master will decrease coverage by 0.10%.
The diff coverage is 87.91%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12729      +/-   ##
==========================================
- Coverage   43.09%   42.99%   -0.11%     
==========================================
  Files         655      656       +1     
  Lines       72347    72334      -13     
==========================================
- Hits        31181    31099      -82     
- Misses      36115    36207      +92     
+ Partials     5051     5028      -23     
Impacted Files Coverage Δ
modules/convert/convert.go 74.58% <50.00%> (-2.04%) ⬇️
modules/convert/issue.go 87.30% <86.20%> (-0.33%) ⬇️
modules/convert/git_commit.go 88.28% <88.28%> (ø)
models/issue_stopwatch.go 70.37% <100.00%> (-2.97%) ⬇️
routers/api/v1/repo/commits.go 57.31% <100.00%> (-14.30%) ⬇️
routers/api/v1/repo/hook.go 26.41% <100.00%> (ø)
routers/api/v1/repo/issue_stopwatch.go 52.63% <100.00%> (ø)
modules/util/timer.go 42.85% <0.00%> (-42.86%) ⬇️
modules/indexer/stats/db.go 52.17% <0.00%> (-8.70%) ⬇️
modules/notification/ui/ui.go 72.22% <0.00%> (-8.34%) ⬇️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afea4fa...1b37b58. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 5, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 6, 2020
@6543 6543 force-pushed the refactor_apiformat-mv branch from ab78f96 to 452a24e Compare September 6, 2020 14:24
Copy link
Member

@lunny lunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

@lunny
Copy link
Member

lunny commented Sep 18, 2020

And I think this could be moved to v1.13 once it's ready.

@6543 6543 requested a review from lunny September 18, 2020 11:59
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 18, 2020
@lunny lunny modified the milestones: 1.14.0, 1.13.0 Sep 18, 2020
@lunny lunny merged commit 1418288 into go-gitea:master Sep 18, 2020
@6543 6543 deleted the refactor_apiformat-mv branch September 18, 2020 12:17
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them type/refactoring Existing code has been cleaned up. There should be no new functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Note] Move StopWatch.APIFormat() to convert package

6 participants