Do not convert file path to lowercase #15023
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6543
approved these changes
Mar 18, 2021
GiteaBot
added
the
lgtm/need 1
6543
added
type/bug
skip-changelog
zeripath
reviewed
Mar 18, 2021
Contributor
zeripath
left a comment
zeripath
left a comment
There was a problem hiding this comment.
This makes the allowed and blocked domains listed case dependent - are we sure that's going to work?
Member
Author
|
Good catch. As of gobwas/glob#37 the needle could be lowered just for the check. |
Contributor
|
it's my fault for not dropping the lowercasing in the original PR and dealing with this properly then. |
zeripath
approved these changes
Mar 18, 2021
GiteaBot
added
lgtm/done
lafriks
approved these changes
Mar 18, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a random integration test error caused by invalid lowercase filepaths.
Example:
Go creates a random working directory
/tmp/tmp.HjvjKQ29GM/integrations/...IsMigrateURLAlloweduses the lowercase path for its test which fails on case sensitive filesystems/tmp/tmp.hjvjkq29gm/integrations/...