Skip to content

Conversation

@fuhrysteve
Copy link
Contributor

Upgrading the reference in the docs to PostgreSQL 14

@fuhrysteve fuhrysteve changed the title upgrade postgres refrence to 14 upgrade postgres refrence to 14 in docs Apr 16, 2022
@fuhrysteve fuhrysteve changed the title upgrade postgres refrence to 14 in docs upgrade postgres reference to 14 in docs Apr 16, 2022
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Apr 16, 2022
@techknowlogick techknowlogick added type/docs This PR mainly updates/creates documentation and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 16, 2022
Copy link
Member

@delvh delvh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason why this is not postgres:latest?
Because with latest we will never need to update it again...

+
+ db:
+ image: postgres:13
+ image: postgres:14
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
+ image: postgres:14
+ image: postgres:latest

+
+ db:
+ image: postgres:13
+ image: postgres:14
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
+ image: postgres:14
+ image: postgres:latest

+
+ db:
+ image: postgres:13
+ image: postgres:14
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
+ image: postgres:14
+ image: postgres:latest

同上,首先在 docker 容器里部署一个 pgsql 数据库
```
docker run -e "POSTGRES_DB=test" -p 5432:5432 --rm --name pgsql postgres:13 #(just ctrl-c to stop db and clean the container)
docker run -e "POSTGRES_DB=test" -p 5432:5432 --rm --name pgsql postgres:14 #(just ctrl-c to stop db and clean the container)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
docker run -e "POSTGRES_DB=test" -p 5432:5432 --rm --name pgsql postgres:14 #(just ctrl-c to stop db and clean the container)
docker run -e "POSTGRES_DB=test" -p 5432:5432 --rm --name pgsql postgres:latest #(just ctrl-c to stop db and clean the container)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m generally always hesitant to document “latest” as the tag someone should use, as it can change meaning without expectation

@GiteaBot GiteaBot added the lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. label Apr 16, 2022
@techknowlogick techknowlogick merged commit 695c4b4 into go-gitea:main Apr 16, 2022
zjjhot added a commit to zjjhot/gitea that referenced this pull request Apr 18, 2022
* giteaofficial/main:
  [skip ci] Updated translations via Crowdin
  [skip ci] Updated licenses and gitignores
  upgrade postgres refrence to 14 (go-gitea#19416)
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 24, 2022
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/docs This PR mainly updates/creates documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants