Skip to content

Conversation

@secsys-go
Copy link

Overview

This pull request introduces a fuzz driver that addresses issue #20316. The purpose of this fuzz driver is to rigorously test the getPostgreSQLConnectionString API by injecting mutated data into its arguments. By doing so, we aim to enhance our continuous testing efforts and ensure the robustness of this API.

Details

The fuzz driver has been designed to thoroughly exercise the getPostgreSQLConnectionString API.
It accomplishes this by systematically injecting various forms of mutated data into the API's arguments.
Through this approach, we can identify potential vulnerabilities and edge cases that might otherwise go unnoticed.

Additional Information

We want to highlight that we have already developed numerous fuzz drivers, each serving as a valuable addition to our testing suite. If this PR is well-received, we are eager to contribute more fuzz drivers to further bolster our testing capabilities.

Thus, we are eager for your feedback and guidance on the process of adding fuzz drivers. Specifically, we would appreciate insights on the following:

  • Deployment: How should we handle the deployment of these fuzz drivers within the project's testing infrastructure?
  • Testing Metrics: Are there specific testing metrics or criteria that you consider essential for evaluating the effectiveness of these fuzz drivers?
  • Any Other Concerns: Please let us know if you have any other concerns or preferences related to the inclusion of fuzz drivers in the project.

Thank you for considering this contribution, and we look forward to your feedback.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 7, 2023
@wxiaoguang
Copy link
Contributor

AI-written code? Some lines seem nonsense.

@wxiaoguang wxiaoguang added the issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail label Sep 7, 2023
@secsys-go
Copy link
Author

No, it's not AI-written code. It is generated automatically by our tool. The nonsense lines are here for integratation of fuzz driver building envirtonment and code correctness.

@wxiaoguang wxiaoguang removed the issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail label Sep 7, 2023
@wxiaoguang
Copy link
Contributor

It doesn't pass the lint. TBH, I have no idea about it at the moment.

@thaJeztah
Copy link

@wxiaoguang I would be wary of these contributions, and I highly doubt these are legit, without further evidence; see the discussion on rclone/rclone#7283 (comment)

But also other contributions;

@techknowlogick
Copy link
Member

Thanks for the heads up @thaJeztah (and for your work on docker). I had assumed this was related to the work @AdamKorcz had been doing, as he had previously set up the other tests that exist in our repo.

@techknowlogick
Copy link
Member

Will close this PR, but if @secsys-go can get this PR working, and perhaps in the format that the google fuzzer project accepts, then please feel free to re-open.

@thaJeztah
Copy link

Yes, I'm happy to be proven wrong, but at least wanted to issue a warning, as I currently don't think these are legit contributions.

@go-gitea go-gitea locked as resolved and limited conversation to collaborators Dec 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants