Skip to content

Improve CSS helper naming #28769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 12, 2024
Merged

Improve CSS helper naming #28769

merged 1 commit into from
Jan 12, 2024

Conversation

@wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Jan 12, 2024

  • gt-w-100 => gt-w-full to match tailwind
  • clarify gt-hidden priority

@wxiaoguang wxiaoguang added type/refactoring Existing code has been cleaned up. There should be no new functionality. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Jan 12, 2024
@wxiaoguang wxiaoguang added this to the 1.22.0 milestone Jan 12, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 12, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 12, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 12, 2024
@yardenshoham yardenshoham added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jan 12, 2024
@wxiaoguang wxiaoguang merged commit 34a0684 into go-gitea:main Jan 12, 2024
@wxiaoguang wxiaoguang deleted the improve-css branch January 12, 2024 12:28
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jan 12, 2024
fuxiaohei pushed a commit to fuxiaohei/gitea that referenced this pull request Jan 17, 2024
@wxiaoguang @fuxiaohei
Improve CSS helper naming (go-gitea#28769)
6c19893 
* `gt-w-100` => `gt-w-full` to match tailwind
* clarify `gt-hidden` priority
silverwind pushed a commit to silverwind/gitea that referenced this pull request Feb 20, 2024
@wxiaoguang @silverwind
Improve CSS helper naming (go-gitea#28769)
2284c64 
* `gt-w-100` => `gt-w-full` to match tailwind
* clarify `gt-hidden` priority
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lunny lunny lunny approved these changes

@delvh delvh delvh approved these changes

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/refactoring Existing code has been cleaned up. There should be no new functionality.

Projects

None yet

Milestone

1.22.0

Development

Successfully merging this pull request may close these issues.

5 participants

@wxiaoguang @lunny @delvh @yardenshoham @GiteaBot