Remove jQuery AJAX from the repo tag edit form #29526
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed all jQuery AJAX calls and replaced with our fetch wrapper - Tested the repo tag edit form functionality and it works as before Signed-off-by: Yarden Shoham <git@yardenshoham.com>
GiteaBot
added
the
lgtm/need 2
yardenshoham
added
the
type/refactoring
delvh
approved these changes
Mar 1, 2024
GiteaBot
added
lgtm/need 1
silverwind
reviewed
Mar 1, 2024
web_src/js/features/repo-home.js
Outdated
| if (xhr.responseJSON.invalidTopics.length > 0) { | ||
| topicPrompts.formatPrompt = xhr.responseJSON.message; | ||
| } catch (error) { | ||
| if (error.response?.status === 422) { |
There was a problem hiding this comment.
What is error.response? I don't think it's part of the fetch standard. Also I think the logic is wrong because fetch will not throw on negative status codes. Fetch only throws on network errors, nothing else.
There was a problem hiding this comment.
I thought it throws. I will fix it
delvh
approved these changes
Mar 1, 2024
lunny
approved these changes
Mar 2, 2024
GiteaBot
added
lgtm/done
yardenshoham
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Mar 2, 2024
* upstream/main: Remove jQuery AJAX from the repo tag edit form (go-gitea#29526)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demo using
fetchinstead of jQuery AJAX