Resolved #296 #324
Merged
Resolved #296 #324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tboerger
reviewed
Dec 1, 2016
Member
tboerger
left a comment
tboerger
left a comment
There was a problem hiding this comment.
Some nitpicking about the template indentation, otherwise LGTM
templates/explore/organizations.tmpl
Outdated
| </div> | ||
| </div> | ||
| {{else}} | ||
| <div>{{$.i18n.Tr "explore.org_no_results"}}</div> |
| <p class="time">{{$.i18n.Tr "org.repo_updated"}} {{TimeSince .Updated $.i18n.Lang}}</p> | ||
| </div> | ||
| {{else}} | ||
| <div> |
templates/explore/users.tmpl
Outdated
| </div> | ||
| </div> | ||
| {{else}} | ||
| <div>{{$.i18n.Tr "explore.user_no_results"}}</div> |
Member
|
LGTM |
tboerger
added
the
lgtm/need 1
Member
|
I will still give you my LGTM |
tboerger
added
lgtm/done
Member
|
Please make PR titles meaningful, so those of us receiving notifications by mail can tell what it is about w/out having to open a referenced ticket to know. (and I think it'll also help with automating Changelog if we take the GitLab path) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.