Use LFS object size instead of blob size when viewing a LFS file

[surya-purohit]

shows the main LFS filesize instead of the pointer filesize when viewing a file

[wxiaoguang]

Thank you for the PR, but I think we shouldn't use a quick patch for this requirement.

All existing code assumes that "fileSize is the size of blob in the commit", if you changed this assumption, it would cause bugs.

The first rule: do not change widely used definition in existing code unless you are pretty sure it is safe.

---

Update: the change is right, need to revert to the old behavior

[surya-purohit]

Thank you for the PR, but I think we shouldn't use a quick patch for this requirement.

All existing code assumes that "fileSize is the size of blob in the commit", if you changed this assumption, it would cause bugs.

The first rule: do not change widely used definition in existing code unless you are pretty sure it is safe.

I understand your point — it makes sense not to change a widely used definition without ensuring it’s safe.
It was working the same way in v1.24.4, and the View File UI displays the size of the actual LFS file rather than the pointer, which is why I approached it this way.
Perhaps we can add a check here — if it’s an LFS file, show the LFS file size; otherwise, show the regular file size.

[wxiaoguang]

It was working the same way in v1.24.4, and the View File UI displays the size of the actual LFS file rather than the pointer, which is why I approached it this way.

Hmm, you are right. Related to Add support for 3D/CAD file formats preview (#34794)

In old code, fileSize does sometimes mean blob size, sometimes mean LFS size. So maybe it's safe to revert the old behavior. Will take a look again.

[wxiaoguang]

Made a small change in bd02218 , use a new name blobOrLfsSize, then it seems clearer now 😄

[wxiaoguang]

And added more tests in 7ddf3b2 , the behavior should be stable now.