Skip to content

Fix various bugs #35684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 18, 2025
Merged

Fix various bugs #35684

merged 4 commits into from
Oct 18, 2025

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Oct 16, 2025 •
edited
Loading

  1. Fix incorrect column in applySubscribedCondition, add a test
  2. Fix debian version parsing, add more tests fix Debian repo does not support the multi digit epoch #35695
  3. Fix log level for HTTP errors, fix gitea returning 404 responses for theme css file, but not logging anything at server side #35651
  4. Fix abused "panic" handler in API Migrate
  5. Fix the redirection from PR to issue, add a test
  6. Fix Actions variable & secret name validation, add more tests
    • envNameCIRegexMatch is unnecessary, removed
    • validating in "delete" function doesn't make sense, removed
  7. Fix incorrect link in release email

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 16, 2025
@github-actions github-actions bot added modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files labels Oct 16, 2025
@wxiaoguang wxiaoguang mentioned this pull request Oct 16, 2025
Closed
@wxiaoguang wxiaoguang force-pushed the fix-various-bug branch 5 times, most recently from 6d5b910 to a2ea7fb Compare October 16, 2025 17:27
@wxiaoguang wxiaoguang requested a review from Copilot October 16, 2025 17:27
Copilot

This comment was marked as resolved.

Sign in to view

lunny
lunny reviewed Oct 16, 2025
View reviewed changes
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 16, 2025
@wxiaoguang wxiaoguang mentioned this pull request Oct 18, 2025
Closed
delvh
delvh approved these changes Oct 18, 2025
View reviewed changes
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 18, 2025
wxiaoguang and others added 2 commits October 19, 2025 00:06
@wxiaoguang @delvh
Update modules/web/routing/logger.go
8d66b19 
Co-authored-by: delvh <dev.lh@web.de>
Signed-off-by: wxiaoguang <wxiaoguang@gmail.com>
@wxiaoguang
Merge branch 'main' into fix-various-bug
36b6eef
@wxiaoguang wxiaoguang merged commit 2d36a0c into go-gitea:main Oct 18, 2025
26 checks passed
@GiteaBot GiteaBot added this to the 1.26.0 milestone Oct 18, 2025
@wxiaoguang wxiaoguang deleted the fix-various-bug branch October 18, 2025 16:37
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Oct 18, 2025
@wxiaoguang @delvh @GiteaBot
Fix various bugs (go-gitea#35684)
6ad0940 
1. Fix incorrect column in `applySubscribedCondition`, add a test
2. Fix debian version parsing, add more tests fix go-gitea#35695
3. Fix log level for HTTP errors, fix go-gitea#35651
4. Fix abused "panic" handler in API `Migrate`
5. Fix the redirection from PR to issue, add a test
6. Fix Actions variable & secret name validation, add more tests
    * envNameCIRegexMatch is unnecessary, removed
    * validating in "delete" function doesn't make sense, removed
7. Fix incorrect link in release email

---------

Signed-off-by: wxiaoguang <wxiaoguang@gmail.com>
Co-authored-by: delvh <dev.lh@web.de>
@GiteaBot GiteaBot mentioned this pull request Oct 18, 2025
Merged
@GiteaBot GiteaBot added the backport/done All backports for this PR have been created label Oct 18, 2025
wxiaoguang pushed a commit that referenced this pull request Oct 18, 2025
@GiteaBot
Fix various bugs (#35684) (#35696)
4af1d58 
Backport #35684 by wxiaoguang
zjjhot added a commit to zjjhot/gitea that referenced this pull request Oct 20, 2025
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
f9d9470 
* giteaofficial/main:
  Avoid emoji mismatch and allow to only enable chosen emojis (go-gitea#35692)
  feat(diff): Enable commenting on expanded lines in PR diffs (go-gitea#35662)
  Fix various bugs (go-gitea#35684)
  Fix workflow run event status while rerunning a failed job (go-gitea#35689)
  Use gitrepo.Repository instead of wikipath (go-gitea#35398)
  [skip ci] Updated translations via Crowdin
  Bump `actions/labeler` to v6 (go-gitea#35681)
  Use LFS object size instead of blob size when viewing a LFS file (go-gitea#35679)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@lunny lunny lunny approved these changes

@delvh delvh delvh approved these changes

Assignees

No one assigned

Labels

backport/done All backports for this PR have been created backport/v1.25 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files type/bug

Projects

None yet

Milestone

1.26.0

Development

Successfully merging this pull request may close these issues.

Debian repo does not support the multi digit epoch gitea returning 404 responses for theme css file, but not logging anything at server side

4 participants

@wxiaoguang @lunny @delvh @GiteaBot