Skip to content

Conversation

@wxiaoguang
Copy link
Contributor

And by the way, remove the legacy TODO, split large functions into small ones, and add more tests

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 20, 2025
@github-actions github-actions bot added modifies/go Pull requests that update Go code modifies/cli PR changes something on the CLI, i.e. gitea doctor or gitea admin labels Oct 20, 2025
@wxiaoguang wxiaoguang force-pushed the fix-legacy branch 2 times, most recently from 203e2ea to be8827b Compare October 20, 2025 06:08
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 20, 2025
@wxiaoguang wxiaoguang force-pushed the fix-legacy branch 3 times, most recently from 7f0ec60 to 5617db2 Compare October 20, 2025 08:06
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 20, 2025
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Oct 20, 2025
@lunny lunny merged commit b2ee5be into go-gitea:main Oct 20, 2025
26 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Oct 20, 2025
@wxiaoguang wxiaoguang deleted the fix-legacy branch October 20, 2025 23:16
wxiaoguang added a commit to wxiaoguang/gitea that referenced this pull request Oct 20, 2025
And by the way, remove the legacy TODO, split large functions into small
ones, and add more tests
# Conflicts:
#	cmd/serv.go
wxiaoguang added a commit that referenced this pull request Oct 21, 2025
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Oct 21, 2025
And by the way, remove the legacy TODO, split large functions into small
ones, and add more tests
@GiteaBot GiteaBot added the backport/done All backports for this PR have been created label Oct 21, 2025
wxiaoguang added a commit that referenced this pull request Oct 21, 2025
Backport #35708 by wxiaoguang

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
zjjhot added a commit to zjjhot/gitea that referenced this pull request Oct 23, 2025
* giteaofficial/main:
  Fix external render (go-gitea#35727)
  Refactor Actions Token Access (go-gitea#35688)
  Honor delete branch on merge repo setting when using merge API (go-gitea#35488)
  Don't block site admin's operation if SECRET_KEY is lost (go-gitea#35721)
  [skip ci] Updated translations via Crowdin
  fix attachment file size limit in server backend (go-gitea#35519)
  Make restricted users can access public repositories (go-gitea#35693)
  Fix various trivial problems (go-gitea#35714)
  Refactor legacy code (go-gitea#35708)
  Add quick approve button on PR page (go-gitea#35678)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport/done All backports for this PR have been created backport/v1.25 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/cli PR changes something on the CLI, i.e. gitea doctor or gitea admin modifies/go Pull requests that update Go code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants