Skip to content

Refactor legacy code, fix LFS auth bypass, fix symlink bypass (#35708) #35713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 21, 2025
Merged

Refactor legacy code, fix LFS auth bypass, fix symlink bypass (#35708) #35713

merged 1 commit into from
Oct 21, 2025

Conversation

@wxiaoguang
Copy link
Contributor

Backport #35708

@wxiaoguang
Refactor legacy code (go-gitea#35708)
83b9e04 
And by the way, remove the legacy TODO, split large functions into small
ones, and add more tests
# Conflicts:
#	cmd/serv.go
@GiteaBot GiteaBot added this to the 1.24.7 milestone Oct 20, 2025
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 20, 2025
@github-actions github-actions bot added modifies/go Pull requests that update Go code modifies/cli PR changes something on the CLI, i.e. gitea doctor or gitea admin labels Oct 20, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 21, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 21, 2025
@wxiaoguang wxiaoguang merged commit e818de1 into go-gitea:release/v1.24 Oct 21, 2025
26 checks passed
@wxiaoguang wxiaoguang deleted the fix-legacy-1.24 branch October 21, 2025 01:10
@wxiaoguang wxiaoguang changed the title Refactor legacy code (#35708) Refactor legacy code, fix LFS auth bypass, fix symlink bypass (#35708) Oct 26, 2025
@wxiaoguang wxiaoguang added the topic/security Something leaks user information or is otherwise vulnerable. Should be fixed! label Oct 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lunny lunny lunny approved these changes

@delvh delvh delvh approved these changes

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/cli PR changes something on the CLI, i.e. gitea doctor or gitea admin modifies/go Pull requests that update Go code topic/security Something leaks user information or is otherwise vulnerable. Should be fixed!

Projects

None yet

Milestone

1.24.7

Development

Successfully merging this pull request may close these issues.

4 participants

@wxiaoguang @lunny @delvh @GiteaBot