upgrade go mail to 0.7.2 and fix the bug #35833
Merged
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunny
added
backport/v1.24
GiteaBot
added
the
lgtm/need 2
github-actions
bot
added
modifies/go
|
That's just a workaround, not the proper fix. The proper fix must be to not import https://github.com/wneessen/go-mail/wiki/Simple-Mailer-Example |
Yes, I just need that to avoid the vul ASAP. I will send another PR to follow the suggestion to use a high level API. |
Merged
silverwind
approved these changes
Nov 3, 2025
GiteaBot
added
lgtm/need 1
Zettat123
approved these changes
Nov 3, 2025
GiteaBot
added
lgtm/done
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Nov 3, 2025
lunny
added a commit
that referenced
this pull request
Nov 3, 2025
Backport #35833 by @lunny patch from wneessen/go-mail#504 (comment). Thanks to @wneessen Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
patch from wneessen/go-mail#504 (comment).
Thanks to @wneessen