Skip to content

Update to go 1.25.4 #35877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 6, 2025
Merged

Update to go 1.25.4 #35877

merged 1 commit into from
Nov 6, 2025
+1 −1

Conversation

@silverwind
Copy link
Member

@silverwind silverwind commented Nov 6, 2025

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 6, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 6, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 6, 2025
@silverwind silverwind merged commit aaa8033 into go-gitea:main Nov 6, 2025
25 checks passed
@GiteaBot GiteaBot added this to the 1.26.0 milestone Nov 6, 2025
@silverwind silverwind deleted the go1254 branch November 6, 2025 06:04
@wxiaoguang
Copy link
Contributor

wxiaoguang commented Nov 6, 2025

CI failure:

758.4 Running go generate...
758.5 go: go.mod requires go >= 1.25.4 (running go 1.25.3; GOTOOLCHAIN=local)
758.5 make: *** [Makefile:755: generate-go] Error 1

@silverwind
Copy link
Member Author

silverwind commented Nov 6, 2025

Link to run?

@wxiaoguang
Copy link
Contributor

wxiaoguang commented Nov 6, 2025

All main branch, including this PR's commit

image

@TheFox0x7
Copy link
Contributor

TheFox0x7 commented Nov 6, 2025

https://github.com/go-gitea/gitea/actions/runs/19129348180/job/54666098525

@silverwind
Copy link
Member Author

silverwind commented Nov 6, 2025 •
edited
Loading

Hmm I think this is because the alpine image still has the old version. I wonder whether we should move to declare go versions in two parts:

go 1.25.0
toolchain go1.25.4

This should make go download the requested toolchain on demand an we basically specify >= 1.25.0 is the minimum version, but this might be problematic for some security scanners.

@silverwind
Copy link
Member Author

silverwind commented Nov 6, 2025

Another option would be to set GOTOOLCHAIN=auto to enable toolchain downloads. For some reason these builds run with GOTOOLCHAIN=local which inhibits downloads.

@silverwind silverwind mentioned this pull request Nov 6, 2025
Closed
@silverwind
Copy link
Member Author

silverwind commented Nov 6, 2025

Opened #35883.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lunny lunny lunny approved these changes

@delvh delvh delvh approved these changes

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/dependencies

Projects

None yet

Milestone

1.26.0

Development

Successfully merging this pull request may close these issues.

6 participants

@silverwind @wxiaoguang @TheFox0x7 @lunny @delvh @GiteaBot