-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
Add missing dependency of database tests on backend #36073
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
CI failures are unrelated and will be fixed with #36074. |
Actually no, not entirely unrelated. |
|
Well, I don't think this "fix" is right and can be approved as the current implementation. @silverwind @delvh , see the CI failures. There are more details. |
|
Interesting. Clearly the dependency is real because the workflow in question first builds backend, and then runs the test. However, the test is run with environment variables set that fail the backend build. My suggestion would be to drop the CGO_ENABLED=0 which would then make the backend buildable as part of the test but I am not expert on go and don't know what this was supposed to accomplish. |
|
I see. cgo, at least the version you use is broken on Arm due to bogus inline assembly. |
|
I think we may just need to add Line 93 in 46d7ade
|
42ab49e to
7835f8b
Compare
CGO is required for tests that use -race as well as some other build options. On arm64 the build fails when CGO is enabled because of some assembly error.
fixes this error:
make test-sqlite
go test -c code.gitea.io/gitea/tests/integration -o integrations.sqlite.test -tags ' sqlite sqlite_unlock_notify'
sed -e 's|{{REPO_TEST_DIR}}||g' \
-e 's|{{TEST_LOGGER}}|test,file|g' \
-e 's|{{TEST_TYPE}}|integration|g' \
tests/sqlite.ini.tmpl > tests/sqlite.ini
GITEA_ROOT="/home/hramrach/gitea" GITEA_CONF=tests/sqlite.ini ./integrations.sqlite.test
Could not find gitea binary at /home/hramrach/gitea/gitea
make: *** [Makefile:506: test-sqlite] Error 1
No need to build it explicitly, db tests now depend on it.
Missing make file dependency:
git clone https://github.com/go-gitea/gitea.git
make -C gitea test-sqlite
go test -c code.gitea.io/gitea/tests/integration -o integrations.sqlite.test -tags ' sqlite sqlite_unlock_notify'
sed -e 's|{{REPO_TEST_DIR}}||g'
-e 's|{{TEST_LOGGER}}|test,file|g'
-e 's|{{TEST_TYPE}}|integration|g'
tests/sqlite.ini.tmpl > tests/sqlite.ini
GITEA_ROOT="/home/hramrach/gitea" GITEA_CONF=tests/sqlite.ini ./integrations.sqlite.test
Could not find gitea binary at /home/hramrach/gitea/gitea
make: *** [Makefile:506: test-sqlite] Error 1