Fix SVG size calulation, only use style attribute
#36133
Merged
+115
−88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
This was referenced Dec 11, 2025
delvh
reviewed
Dec 12, 2025
delvh
approved these changes
Dec 12, 2025
GiteaBot
added
lgtm/need 1
Contributor
|
Made a small change for the transparent image in #35863 
|
wxiaoguang
added
backport/done
wxiaoguang
approved these changes
Dec 12, 2025
GiteaBot
added
lgtm/done
lafriks
approved these changes
Dec 12, 2025
lafriks
pushed a commit
that referenced
this pull request
Dec 12, 2025
Backport of #36133, only the bugfix part. --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Member
Author
BTW this mask image should be made darker in dark theme, I will probably follow up on that later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #35863
The old code had a conflict between using HTML attributes vs. style properties where the style was overriding the previously set HTML attributes:
I made it so in all cases only
styleproperties are used and the previous width/height values are now set viastyle. Also I did a number of much-needed typescript improvements to the file.