Skip to content

Conversation

@adelowo
Copy link
Member

@adelowo adelowo commented Jan 28, 2019

Fixes #5882

This PR makes sure to actually use the config value while creating a user.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 28, 2019
@codecov-io
Copy link

codecov-io commented Jan 28, 2019

Codecov Report

Merging #5886 into master will decrease coverage by 0.15%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5886      +/-   ##
==========================================
- Coverage   38.01%   37.85%   -0.16%     
==========================================
  Files         328      328              
  Lines       48328    48329       +1     
==========================================
- Hits        18370    18295      -75     
- Misses      27319    27401      +82     
+ Partials     2639     2633       -6
Impacted Files Coverage Δ
models/user.go 48.79% <100%> (+0.04%) ⬆️
models/issue_indexer.go 57.64% <0%> (-12.95%) ⬇️
models/repo_indexer.go 44.49% <0%> (-12.29%) ⬇️
models/issue_list.go 63.11% <0%> (-7.93%) ⬇️
modules/log/xorm.go 36.61% <0%> (-7.05%) ⬇️
models/repo.go 43.85% <0%> (-0.6%) ⬇️
models/migrations/migrations.go 2.61% <0%> (+1.08%) ⬆️
modules/process/manager.go 81.15% <0%> (+4.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8917d66...1eb59bd. Read the comment docs.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 28, 2019
@zeripath
Copy link
Contributor

@adelowo might be good to add a test of this though.

@adelowo
Copy link
Member Author

adelowo commented Jan 29, 2019

Yeah true, Will add a test.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 30, 2019
@techknowlogick
Copy link
Member

make LG-TM work

@techknowlogick techknowlogick merged commit 6dc2f40 into go-gitea:master Jan 30, 2019
@adelowo adelowo deleted the fix_5882 branch January 30, 2019 17:05
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DISABLE_REGULAR_ORG_CREATION is not working

6 participants