Skip to content

Set the ldflags to static value within makefile #709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 20, 2017
Merged

Set the ldflags to static value within makefile #709

merged 1 commit into from
Jan 20, 2017

Conversation

@tboerger
Copy link
Member

@tboerger tboerger commented Jan 20, 2017

Should finally really fix #540 (comment)

@tboerger tboerger added the type/enhancement An improvement of existing functionality label Jan 20, 2017
@tboerger tboerger added this to the 1.1.0 milestone Jan 20, 2017
@lunny
Copy link
Member

lunny commented Jan 20, 2017

trusted LGTM

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 20, 2017
@Bwko
Copy link
Member

Bwko commented Jan 20, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 20, 2017
@tboerger tboerger merged commit 369972b into go-gitea:master Jan 20, 2017
This was referenced Jan 20, 2017
Closed
Merged
@tboerger tboerger deleted the ldflags branch January 28, 2017 16:23
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality

Projects

None yet

Milestone

1.1.0

Development

Successfully merging this pull request may close these issues.

When using make: flag provided but not defined

3 participants

@tboerger @lunny @Bwko