Skip to content

Conversation

@kubatyszko
Copy link
Contributor

Hi there,

We happen to have a user whose login is "raw", and it's a reserved keyword in Gitea,
I made a quick patch to remove it from the list.

I don't see a reason for it being disallowed, gitea works perfectly fine...

(I"m positive that many other reserved keywords also don't have to be disallowed)

Thanks

@codecov-io
Copy link

Codecov Report

Merging #7503 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7503      +/-   ##
==========================================
+ Coverage   41.21%   41.21%   +<.01%     
==========================================
  Files         469      469              
  Lines       63533    63533              
==========================================
+ Hits        26182    26184       +2     
+ Misses      33933    33931       -2     
  Partials     3418     3418
Impacted Files Coverage Δ
models/user.go 50.5% <ø> (ø) ⬆️
modules/log/event.go 65.64% <0%> (+1.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e2996c...ff39ec4. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 17, 2019
@silverwind
Copy link
Member

It is used in raw url like https://try.gitea.io/silverwind/symlink-test/raw/branch/master/file, thought I'm not sure if that will ever conflict with usernames in other URL schemes.

@silverwind
Copy link
Member

Also seems to be a reserved username on GitHub: https://github.com/raw. So generally I'd say we should probably also not allow to so we can at some point in the future make use of the $domain/raw namespace.

@lunny lunny closed this Jul 19, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
@delvh delvh added issue/not-a-bug The reported issue is the intended behavior or the problem is not inside Gitea and removed reviewed/invalid labels Oct 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

issue/not-a-bug The reported issue is the intended behavior or the problem is not inside Gitea lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants