This repository was archived by the owner on Dec 7, 2021. It is now read-only.
Conversation
This was referenced Dec 9, 2016
Member
|
trusted LGTM |
Member
|
LGTM |
Contributor
|
But why did you drop the 404 entirely? No reason for that. I didn't had any translations. |
Member
Author
|
The 404 page gets generated once, with the last language (Chinese) that's why I dropped it and I would keep the default 404 error page of the Webserver |
Member
|
We could keep 404 an english words. Only one 404 is OKay. |
Member
Author
|
Currently it gets only translated to chinese, that's why I have dropped it for now. |
kolaente
pushed a commit
to kolaente/theme
that referenced
this pull request
May 13, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.