Skip to content

Conversation

@liggitt
Copy link
Contributor

@liggitt liggitt commented Jun 29, 2016

Get clean gofmt/govet/golint checks, add makefile and pre-push hook to simplify running checks, invoke checks in travis

@liggitt
Copy link
Contributor Author

liggitt commented Jun 30, 2016

@johnweldon any preference on the location/names of the verify scripts?

@johnweldon
Copy link
Member

@liggitt I usually have a scripts folder with verify.sh that does the go fmt check and the go vet check, and then a pre-push.sh that wraps that, and is used for the git pre-push hook.

@liggitt
Copy link
Contributor Author

liggitt commented Jul 1, 2016

@johnweldon after playing with scripts for a while, I think I like a makefile better... lets you do things like this:

# runs all default tasks
make
# just run tests
make test
# just run linting
make lint
...

what do you think?

@johnweldon
Copy link
Member

@liggitt I'm great with Makefile too - agree it can be useful for different targets or conditional targets

@liggitt liggitt merged commit 537128f into go-ldap:master Jul 1, 2016
@liggitt liggitt deleted the godoc-gofmt branch July 1, 2016 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants