Skip to content

test(mangling/ucd): added tests to cover UCD-based generation commands - #42

Merged
fredbi merged 1 commit into
go-openapi:masterfrom
fredbi:test/added-missing-coverage
Sep 3, 2026
Merged

test(mangling/ucd): added tests to cover UCD-based generation commands#42
fredbi merged 1 commit into
go-openapi:masterfrom
fredbi:test/added-missing-coverage

Conversation

@fredbi

@fredbi fredbi commented Sep 3, 2026

Copy link
Copy Markdown
Member

Bugs fixed:

  • generation was referencing a deprecated location
  • numeral interpretation of NaN/Inf is handled by the mangler, not in the tables, where it yields an incorrect result

Change type

Please select: 🆕 New feature or enhancement|🔧 Bug fix'|📃 Documentation update

Short description

Fixes

Full description

Checklist

  • I have signed all my commits with my name and email (see DCO. This does not require a PGP-signed commit
  • I have rebased and squashed my work, so only one commit remains
  • I have added tests to cover my changes.
  • I have properly enriched go doc comments in code.
  • I have properly documented any breaking change.

@fredbi
fredbi force-pushed the test/added-missing-coverage branch from beebf2e to 3999583 Compare September 3, 2026 16:17
@codecov

codecov Bot commented Sep 3, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 97.14286% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 91.10%. Comparing base (d4340dd) to head (4d7d769).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
mangling/numbers/fraction.go 95.45% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master      #42       +/-   ##
===========================================
+ Coverage   79.69%   91.10%   +11.41%     
===========================================
  Files          81       81               
  Lines        4999     5028       +29     
===========================================
+ Hits         3984     4581      +597     
+ Misses       1014      445      -569     
- Partials        1        2        +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

Bugs fixed:
* generation was referencing a deprecated location
* numeral interpretation of NaN/Inf is handled by the mangler, not in
  the tables, where it yields an incorrect result
* the generators recorded the UCD source path as filepath.Rel returned
  it, so a regen on Windows rewrote "Generated from v15/DerivedName.txt"
  with a backslash and churned every table; filepath.ToSlash pins it

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
@fredbi
fredbi force-pushed the test/added-missing-coverage branch from 3999583 to 4d7d769 Compare September 3, 2026 16:34
@fredbi
fredbi merged commit 8913719 into go-openapi:master Sep 3, 2026
22 checks passed
@fredbi
fredbi deleted the test/added-missing-coverage branch September 3, 2026 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant